linux-mips
[Top] [All Lists]

Re: [PATCH V5 1/3] ASoC: Alchemy AC97C/I2SC audio support

To: Manuel Lauss <manuel.lauss@googlemail.com>
Subject: Re: [PATCH V5 1/3] ASoC: Alchemy AC97C/I2SC audio support
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
Date: Tue, 26 Jul 2011 15:47:18 +0100
Cc: alsa-devel@vger.kernel.org, Liam Girdwood <lrg@ti.com>, Linux-MIPS <linux-mips@linux-mips.org>
In-reply-to: <CAOLZvyFzHFGFvFrWigLi_oHpdQBp1ZCsRBEU8tF-62X8VaCd_Q@mail.gmail.com>
References: <1311594287-31576-1-git-send-email-manuel.lauss@googlemail.com> <1311594287-31576-2-git-send-email-manuel.lauss@googlemail.com> <20110726143112.GF7285@opensource.wolfsonmicro.com> <CAOLZvyFzHFGFvFrWigLi_oHpdQBp1ZCsRBEU8tF-62X8VaCd_Q@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Jul 26, 2011 at 04:43:16PM +0200, Manuel Lauss wrote:
> On Tue, Jul 26, 2011 at 4:31 PM, Mark Brown

> >> +     case (~DMA_D0 & ~DMA_D1):
> >> +             pr_debug("DMA %d empty irq.\n", stream->dma);

> > This case should return IRQ_NONE really since it didn't handle an
> > interrupt...

> If that last case ever happens the DMA engine is broken, as it shouldn't
> issue interrupts when no transfer is in progress.  The errata sheets don't
> mention anything (yet).

In that case this should be an error rather than debug level print and
I'd say the IRQ_NONE thing definitely applies.

<Prev in Thread] Current Thread [Next in Thread>