Re: [PATCH v2 04/11] bcma: add SOC bus

[Rafał Miłecki <zajec5@gmail.com>]

2011/7/16 Hauke Mehrtens <hauke@hauke-m.de>:
> This patch adds support for using bcma on a Broadcom SoC as the system
> bus. An SoC like the bcm4716 could register this bus and use it to
> searches for the bcma cores and register the devices on this bus.
>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>

Acked-by: Rafał Miłecki <zajec5@gmail.com>

Cleaning enum bcma_hosttype would be nice (see below), but we cal
always easily do this later.


> diff --git a/include/linux/bcma/bcma.h b/include/linux/bcma/bcma.h
> index 6bd7b7f..73fda1c 100644
> --- a/include/linux/bcma/bcma.h
> +++ b/include/linux/bcma/bcma.h
> @@ -16,6 +16,7 @@ enum bcma_hosttype {
>        BCMA_HOSTTYPE_NONE,
>        BCMA_HOSTTYPE_PCI,
>        BCMA_HOSTTYPE_SDIO,
> +       BCMA_HOSTTYPE_SOC,
>  };

I wanted to use BCMA_HOSTTYPE_NONE for SoCs (embedded systems), when I
decided to add it. As we decided SOC is better name than NONE, you
could drop it (NONE one).

-- 
Rafał