linux-mips
[Top] [All Lists]

Re: [PATCH v2 03/11] bcma: add functions to scan cores needed on SoCs

To: Hauke Mehrtens <hauke@hauke-m.de>
Subject: Re: [PATCH v2 03/11] bcma: add functions to scan cores needed on SoCs
From: Rafał Miłecki <zajec5@gmail.com>
Date: Fri, 22 Jul 2011 00:35:01 +0200
Cc: ralf@linux-mips.org, linux-wireless@vger.kernel.org, linux-mips@linux-mips.org, jonas.gorski@gmail.com, mb@bu3sch.de, george@znau.edu.ua, arend@broadcom.com, b43-dev@lists.infradead.org, bernhardloos@googlemail.com, arnd@arndb.de, julian.calaby@gmail.com, sshtylyov@mvista.com
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=U+fioFA7j6d9z9dxChpGgwyy5Htf/m81f2IsKdBcQGw=; b=FglgcHUnc4FHnyXFgnDNhNNpxVwn0jjaU0+RpjxdpngYyhjX5/h6l/zMNIp+QOWGCS ibU1zJtL5U1msVnG8ZS1n83C8h4Quvbxjhwcuq20nE2h1vmP7zTXHDESSgfrPqH4n2ln Zs/5brQnTd/0JEuqHt4P7Y9Abdxqhsrw4cGTs=
In-reply-to: <1310835342-18877-4-git-send-email-hauke@hauke-m.de>
References: <1310835342-18877-1-git-send-email-hauke@hauke-m.de> <1310835342-18877-4-git-send-email-hauke@hauke-m.de>
Sender: linux-mips-bounce@linux-mips.org
2011/7/16 Hauke Mehrtens <hauke@hauke-m.de>:
> @@ -159,5 +159,8 @@ static void bcma_pcicore_serdes_workaround(struct 
> bcma_drv_pci *pc)
>
>  void bcma_core_pci_init(struct bcma_drv_pci *pc)
>  {
> +       if (pc->setup_done)
> +               return;
>        bcma_pcicore_serdes_workaround(pc);
> +       pc->setup_done = true;
>  }

This won't apply to the upstream driver_pci.c. Fix is obvious for me
and you, but could be nice to don't bother John/Ralf.


> +       /* Scan for devices (cores) */
> +       err = bcma_bus_scan_early(bus, &match, core_cc);

Could you update the comment by the way?

-- 
Rafał

<Prev in Thread] Current Thread [Next in Thread>