[Top] [All Lists]

Re: SB16 build error.

To: Ralf Baechle <>
Subject: Re: SB16 build error.
From: Arnd Bergmann <>
Date: Thu, 30 Jun 2011 14:54:16 +0200
Cc: Takashi Iwai <>, Jaroslav Kysela <>,,,,, Florian Fainelli <>,, Richard Henderson <>, Ivan Kokshaysky <>, Matt Turner <>, Benjamin Herrenschmidt <>, Paul Mackerras <>, "David S. Miller" <>,
In-reply-to: <>
References: <> <> <>
User-agent: KMail/1.12.2 (Linux/2.6.31-22-generic; KDE/4.3.2; x86_64; ; )
On Thursday 30 June 2011, Ralf Baechle wrote:
> #define SNDRV_SB_CSP_IOCTL_LOAD_CODE                            \
>         _IOC(_IOC_WRITE,'H', 0x11, sizeof(struct snd_sb_csp_microcode))
> error checking can be bypassed and all will be fine as long as the
> resulting value doesn't result in in a a duplicate case value - which it
> doesn't, at least not in my testing.
> Should work but isn't nice.

Right. It's probably the best we can do. I think we added a few similar
definitions when we originally introduce _IOC_TYPECHECK. The idea was
never to break existing code, but rather to avoid merging new drivers that
use inconsistent ioctl command numbers.


<Prev in Thread] Current Thread [Next in Thread>