linux-mips
[Top] [All Lists]

Re: [RFC v3 03/13] bcma: add functions to scan cores needed on SoCs

To: Hauke Mehrtens <hauke@hauke-m.de>
Subject: Re: [RFC v3 03/13] bcma: add functions to scan cores needed on SoCs
From: Rafał Miłecki <zajec5@gmail.com>
Date: Thu, 30 Jun 2011 08:42:56 +0200
Cc: linux-wireless@vger.kernel.org, linux-mips@linux-mips.org, mb@bu3sch.de, george@znau.edu.ua, arend@broadcom.com, b43-dev@lists.infradead.org, bernhardloos@googlemail.com, arnd@arndb.de, julian.calaby@gmail.com, sshtylyov@mvista.com
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=5BR/9Ztckt4XuS37wCsb1PHxTn7g2+m1a/Z17iJQFqw=; b=UHPkH+j3N30D4MVHq6BkdLFOczvAYUKqNjxm3n+krQU1whU6oXBBuyWDpPtvaIW5/P Jlqf7WiWCu3kX7jqkuUtcrQu/tuvfUKyj9B5FbJ3goyuLsTEaevum1vonDalLqZXV+dr Voj3uCSGnjsK92m5Yd9au4R/hiAR4yo1pDXXw=
In-reply-to: <1309385518-12097-4-git-send-email-hauke@hauke-m.de>
References: <1309385518-12097-1-git-send-email-hauke@hauke-m.de> <1309385518-12097-4-git-send-email-hauke@hauke-m.de>
Sender: linux-mips-bounce@linux-mips.org
2011/6/30 Hauke Mehrtens <hauke@hauke-m.de>:
> +               core->core_index = core_num++;
> +               bus->nr_cores++;
> +
>                pr_info("Core %d found: %s "
>                        "(manuf 0x%03X, id 0x%03X, rev 0x%02X, class 0x%X)\n",
> -                       bus->nr_cores, bcma_device_name(&core->id),
> +                       core->core_index, bcma_device_name(&core->id),
>                        core->id.manuf, core->id.id, core->id.rev,
>                        core->id.class);
>
> -               core->core_index = bus->nr_cores++;
>                list_add(&core->list, &bus->cores);

Didn't you just change core indexes (0, 1, ...) to numbers (1, 2,
...)? It would break enabling IRQs on PCI.

Didn't test it however yet, I'll have access to my machines tomorrow.

-- 
Rafał
<Prev in Thread] Current Thread [Next in Thread>