| To: | linux-wireless@vger.kernel.org, zajec5@gmail.com, linux-mips@linux-mips.org |
|---|---|
| Subject: | [RFC v3 09/13] bcma: add check if sprom is available before accessing it. |
| From: | Hauke Mehrtens <hauke@hauke-m.de> |
| Date: | Thu, 30 Jun 2011 00:11:54 +0200 |
| Cc: | mb@bu3sch.de, george@znau.edu.ua, arend@broadcom.com, b43-dev@lists.infradead.org, bernhardloos@googlemail.com, arnd@arndb.de, julian.calaby@gmail.com, sshtylyov@mvista.com, Hauke Mehrtens <hauke@hauke-m.de> |
| In-reply-to: | <1309385518-12097-1-git-send-email-hauke@hauke-m.de> |
| References: | <1309385518-12097-1-git-send-email-hauke@hauke-m.de> |
| Sender: | linux-mips-bounce@linux-mips.org |
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
drivers/bcma/main.c | 4 +++-
drivers/bcma/sprom.c | 3 +++
2 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/drivers/bcma/main.c b/drivers/bcma/main.c
index 7dd0b16..2750aa5 100644
--- a/drivers/bcma/main.c
+++ b/drivers/bcma/main.c
@@ -160,7 +160,9 @@ int bcma_bus_register(struct bcma_bus *bus)
/* Try to get SPROM */
err = bcma_sprom_get(bus);
- if (err) {
+ if (err == -ENOENT) {
+ pr_err("No SPROM available\n");
+ } else if (err) {
pr_err("Failed to get SPROM: %d\n", err);
return -ENOENT;
}
diff --git a/drivers/bcma/sprom.c b/drivers/bcma/sprom.c
index ffbb0e3..8e8d5cf 100644
--- a/drivers/bcma/sprom.c
+++ b/drivers/bcma/sprom.c
@@ -143,6 +143,9 @@ int bcma_sprom_get(struct bcma_bus *bus)
if (!bus->drv_cc.core)
return -EOPNOTSUPP;
+ if (!(bus->drv_cc.capabilities & BCMA_CC_CAP_SPROM))
+ return -ENOENT;
+
sprom = kcalloc(SSB_SPROMSIZE_WORDS_R4, sizeof(u16),
GFP_KERNEL);
if (!sprom)
--
1.7.4.1
|
| Previous by Date: | [RFC v3 08/13] bcma: add pci(e) host mode, Hauke Mehrtens |
|---|---|
| Next by Date: | [RFC v3 07/13] bcma: get CPU clock, Hauke Mehrtens |
| Previous by Thread: | [RFC v3 08/13] bcma: add pci(e) host mode, Hauke Mehrtens |
| Next by Thread: | [RFC v3 07/13] bcma: get CPU clock, Hauke Mehrtens |
| Indexes: | [Date] [Thread] [Top] [All Lists] |