linux-mips
[Top] [All Lists]

Re: [PATCH] ssb: add __devinit to some functions

To: "John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] ssb: add __devinit to some functions
From: Hauke Mehrtens <hauke@hauke-m.de>
Date: Tue, 21 Jun 2011 20:51:30 +0200
Cc: mb@bu3sch.de, ralf@linux-mips.org, linux-mips@linux-mips.org, linux-wireless@vger.kernel.org
In-reply-to: <20110621183800.GB2273@tuxdriver.com>
References: <20110621150227.GB14197@linux-mips.org> <1308680889-4217-1-git-send-email-hauke@hauke-m.de> <20110621183800.GB2273@tuxdriver.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110516 Lightning/1.0b2 Thunderbird/3.1.10
On 06/21/2011 08:38 PM, John W. Linville wrote:
> On Tue, Jun 21, 2011 at 08:28:09PM +0200, Hauke Mehrtens wrote:
>> Two functions in ssb are using register_pci_controller() which is
>> __devinit. The functions ssb_pcicore_init_hostmode() and
>> ssb_gige_probe() should also be __devinit.
>>
>> This fixes the following warning:
>> WARNING: vmlinux.o(.text+0x2727b8): Section mismatch in reference from the 
>> function ssb_pcicore_init_hostmode() to the function 
>> .devinit.text:register_pci_controller()
>> The function ssb_pcicore_init_hostmode() references
>> the function __devinit register_pci_controller().
>> This is often because ssb_pcicore_init_hostmode lacks a __devinit
>> annotation or the annotation of register_pci_controller is wrong.
>>
>> WARNING: vmlinux.o(.text+0x273398): Section mismatch in reference from the 
>> function ssb_gige_probe() to the function 
>> .devinit.text:register_pci_controller()
>> The function ssb_gige_probe() references
>> the function __devinit register_pci_controller().
>> This is often because ssb_gige_probe lacks a __devinit
>> annotation or the annotation of register_pci_controller is wrong.
>>
>> Reported-by: Ralf Baechle <ralf@linux-mips.org>
> 
> Signed-off-by??
> 

Ops missing, will resend both patches.

Hauke

<Prev in Thread] Current Thread [Next in Thread>