linux-mips
[Top] [All Lists]

Re: [PATCH 02/13] MIPS: ath79: add revision id for the AR933X SoCs

To: Sergei Shtylyov <sshtylyov@mvista.com>
Subject: Re: [PATCH 02/13] MIPS: ath79: add revision id for the AR933X SoCs
From: Gabor Juhos <juhosg@openwrt.org>
Date: Tue, 21 Jun 2011 20:17:18 +0200
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, Kathy Giori <kgiori@qca.qualcomm.com>, "Luis R. Rodriguez" <rodrigue@qca.qualcomm.com>
In-reply-to: <4E0070CA.1070102@mvista.com>
References: <1308597973-6037-1-git-send-email-juhosg@openwrt.org> <1308597973-6037-3-git-send-email-juhosg@openwrt.org> <4E0070CA.1070102@mvista.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; hu-HU; rv:1.9.2.17) Gecko/20110414 Thunderbird/3.1.10
Hi Sergei,

> On 20-06-2011 23:26, Gabor Juhos wrote:
> 
>> Signed-off-by: Gabor Juhos<juhosg@openwrt.org>
>> ---
>>   arch/mips/ath79/setup.c                        |   12 ++++++++++++
>>   arch/mips/include/asm/mach-ath79/ar71xx_regs.h |    4 ++++
>>   arch/mips/include/asm/mach-ath79/ath79.h       |    4 +++-
>>   3 files changed, 19 insertions(+), 1 deletions(-)
> 
>> diff --git a/arch/mips/ath79/setup.c b/arch/mips/ath79/setup.c
>> index dea5af1..4cbd5e0 100644
>> --- a/arch/mips/ath79/setup.c
>> +++ b/arch/mips/ath79/setup.c
>> @@ -116,6 +116,18 @@ static void __init ath79_detect_sys_type(void)
>>           rev = id&  AR724X_REV_ID_REVISION_MASK;
>>           break;
>>
>> +    case REV_ID_MAJOR_AR9330:
>> +        ath79_soc = ATH79_SOC_AR9330;
>> +        chip = "9330";
>> +        rev = (id & AR933X_REV_ID_REVISION_MASK);
>> +        break;
>> +
>> +    case REV_ID_MAJOR_AR9331:
>> +        ath79_soc = ATH79_SOC_AR9331;
>> +        chip = "9331";
>> +        rev = (id & AR933X_REV_ID_REVISION_MASK);
> 
>    Hm, you've just removed such parens in the previous patch, why add more of
> them? :-O

Hm, you are right. I'm sure that I have removed the parentheses from this code
as well, but it seems that I lost that during a rebase process. I will fix this.

Thanks,
Gabor

<Prev in Thread] Current Thread [Next in Thread>