Hi, David/Ralf,
I tried to regenerate a patch for this, and after
git clone git://git.linux-mips.org/pub/scm/linux
I found out that there is arch/mips/mm/mmap.c, but could not find out who/how
this file was merged.
I doubt that I may "git clone" a wrong repo that is no longer valid.
Thanks,
Jian
-----Original Message-----
From: linux-mips-bounce@linux-mips.org
[mailto:linux-mips-bounce@linux-mips.org] On Behalf Of Jian Peng
Sent: Wednesday, May 25, 2011 11:07 AM
To: David Daney
Cc: linux-mips@linux-mips.org; Ralf Baechle
Subject: RE: patch to support topdown mmap allocation in MIPS
Hi, David,
I am willing to get more feedback and sort out issues before I forgot all
details.
I post a simple testing program at
http://www.linux-mips.org/archives/linux-mips/2011-05/msg00252.html
And it was also tested in a real application using mmap heavily and need this
patch to avoid failure.
It is my bad to take your suggestion literally. How about
arch_get_unmapped_area_common()?
Thanks,
Jian
-----Original Message-----
From: David Daney [mailto:ddaney@caviumnetworks.com]
Sent: Wednesday, May 25, 2011 10:58 AM
To: Jian Peng
Cc: linux-mips@linux-mips.org; Ralf Baechle
Subject: Re: patch to support topdown mmap allocation in MIPS
On 05/25/2011 10:47 AM, Jian Peng wrote:
> Hi, Ralf/David,
>
> What else should I do to get this patch merged?
>
Be patient. And tell how it was tested.
Also ....
[...]
> +
> +unsigned long arch_get_unmapped_area_foo(struct file *filp, unsigned long
> addr0,
> + unsigned long len, unsigned long pgoff, unsigned long flags,
> + enum mmap_allocation_direction dir)
I know I suggested the name *_foo, but really I expected you to choose a
better name, as the 'foo' is just the default name for examples.
I think it needs a better name than that.
I will try to test it on my Octeon system sometime.
David Daney
|