linux-mips
[Top] [All Lists]

Re: [PATCH 1/2] MIPS: lantiq: adds missing clk.h functions

To: Manuel Lauss <manuel.lauss@googlemail.com>
Subject: Re: [PATCH 1/2] MIPS: lantiq: adds missing clk.h functions
From: John Crispin <blogic@openwrt.org>
Date: Thu, 09 Jun 2011 20:09:58 +0200
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
In-reply-to: <BANLkTikWCDhUPDX_fJ20+TVoqaq4Y9q5ug@mail.gmail.com>
References: <1307642253-8770-1-git-send-email-blogic@openwrt.org> <BANLkTikWCDhUPDX_fJ20+TVoqaq4Y9q5ug@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.12) Gecko/20100913 Icedove/3.0.7
On 09/06/11 20:06, Manuel Lauss wrote:
> On Thu, Jun 9, 2011 at 7:57 PM, John Crispin <blogic@openwrt.org> wrote:
>   
>> The 2 functions clk_enable() and clk_disable were missing.
>>
>> Signed-of-by: John Crispin <blogic@openwrt.org>
>> Cc: linux-mips@linux-mips.org
>> ---
>>  arch/mips/lantiq/clk.c |   11 +++++++++++
>>  1 files changed, 11 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/mips/lantiq/clk.c b/arch/mips/lantiq/clk.c
>> index 9456089..aba91db 100644
>> --- a/arch/mips/lantiq/clk.c
>> +++ b/arch/mips/lantiq/clk.c
>> @@ -100,6 +100,17 @@ void clk_put(struct clk *clk)
>>  }
>>  EXPORT_SYMBOL(clk_put);
>>
>> +int clk_enable(struct clk *clk)
>> +{
>> +       /* not used */
>> +       return 0;
>> +}
>> +
>> +void clk_disable(struct clk *clk)
>> +{
>> +       /* not used */
>> +}
>> +
>>     
> Shouldn't those be exported as well?
>
> Manuel
>   

you are right they should be.

will resend in a sec, thx !

John


<Prev in Thread] Current Thread [Next in Thread>