linux-mips
[Top] [All Lists]

Re: [PATCH 2/3] WATCHDOG: mtx1-wdt: request gpio before using it

To: Florian Fainelli <florian@openwrt.org>
Subject: Re: [PATCH 2/3] WATCHDOG: mtx1-wdt: request gpio before using it
From: Jamie Iles <jamie@jamieiles.com>
Date: Tue, 7 Jun 2011 10:58:47 +0100
Cc: Wim Van Sebroeck <wim@iguana.be>, linux-mips@linux-mips.org, linux-watchdog@vger.kernel.org, Manuel Lauss <manuel.lauss@googlemail.com>, stable@kernel.org
In-reply-to: <201106021454.20111.florian@openwrt.org>
References: <201106021454.20111.florian@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Jun 02, 2011 at 02:54:20PM +0200, Florian Fainelli wrote:
> Otherwise, the gpiolib autorequest feature will produce a WARN_ON():
> 
> WARNING: at drivers/gpio/gpiolib.c:101 0x8020ec6c()
> autorequest GPIO-215
> [...]
> 
> CC: stable@kernel.org
> Signed-off-by: Florian Fainelli <florian@openwrt.org>
> ---
> diff --git a/drivers/watchdog/mtx-1_wdt.c b/drivers/watchdog/mtx-1_wdt.c
> index 63df28c..16086f8 100644
> --- a/drivers/watchdog/mtx-1_wdt.c
> +++ b/drivers/watchdog/mtx-1_wdt.c
> @@ -214,6 +214,11 @@ static int __devinit mtx1_wdt_probe(struct 
> platform_device *pdev)
>       int ret;
>  
>       mtx1_wdt_device.gpio = pdev->resource[0].start;
> +     ret = gpio_request(mtx1_wdt_device.gpio, "mtx1-wdt");
> +     if (ret < 0) {
> +             dev_err(&pdev->dev, "failed to request gpio");
> +             return ret;
> +     }

Could you use gpio_request_one() here to make sure the GPIO is in the 
correct direction first?

Jamie

<Prev in Thread] Current Thread [Next in Thread>