linux-mips
[Top] [All Lists]

Re: [RFC][PATCH 04/10] bcma: add mips driver

To: Hauke Mehrtens <hauke@hauke-m.de>
Subject: Re: [RFC][PATCH 04/10] bcma: add mips driver
From: Rafał Miłecki <zajec5@gmail.com>
Date: Tue, 7 Jun 2011 00:50:02 +0200
Cc: linux-wireless@vger.kernel.org, linux-mips@linux-mips.org, mb@bu3sch.de, george@znau.edu.ua, arend@broadcom.com, b43-dev@lists.infradead.org, bernhardloos@googlemail.com
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=NOpL3XBkd9eFylF6C9pQ2DSfi05L5RhiVrAJRh++va4=; b=ryGwZjAn3oW9PXAAp23e3ERYI82avF4iVTfttJb6lUNOQi8dhCKIIv2UKS+6uSkct8 QdTziPR4yd69P3WnHS45rcHHpney4iyY9PAt9stKYdW0u0wRqrNd5b47r+0OeLhQ6UhT h4FVK/pM/NN3gcc3SA7WYuqDSJ6l4K3BYh0WY=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=qG0Ds1Da1L3olrLoKlA6UWATUBfbKEjo8D4kDkbpuBXszaOWOY3npTmC/alC5GTatP 2ZMFpenrpau1hjUmG3aeHs9r6QuVzF2qj1HNwacUu/cZi7AU8H5aamph5Ky15Lf9JFad DEMnwhgPYRmf3mghNzNpUXdE/40xG3Avh5z9s=
In-reply-to: <4DED4F6C.5030902@hauke-m.de>
References: <1307311658-15853-1-git-send-email-hauke@hauke-m.de> <1307311658-15853-5-git-send-email-hauke@hauke-m.de> <BANLkTim_TtNVmmyH5J3G0pK-vrWNL1+24A@mail.gmail.com> <4DED4F6C.5030902@hauke-m.de>
Sender: linux-mips-bounce@linux-mips.org
W dniu 7 czerwca 2011 00:06 użytkownik Hauke Mehrtens
<hauke@hauke-m.de> napisał:
> On 06/06/2011 01:23 PM, Rafał Miłecki wrote:
>>> +                       for (i = 0; i < bus->nr_cores; i++)
>>> +                               if ((1 << 
>>> bcma_core_mips_irqflag(&bus->cores[i])) == oldirqflag) {
>>> +                                       
>>> bcma_core_mips_set_irq(&bus->cores[i], 0);
>>> +                                       break;
>>> +                               }
>>
>> Braces for "for".
> Is this needed after the coding guildlines? Shouldn't they be removed if
> they are not needed?

Whoops, after re-checking coding style it seems I was wrong.

-- 
Rafał
<Prev in Thread] Current Thread [Next in Thread>