linux-mips
[Top] [All Lists]

Re: [RFC][PATCH 07/10] bcma: add pci(e) host mode

To: Hauke Mehrtens <hauke@hauke-m.de>
Subject: Re: [RFC][PATCH 07/10] bcma: add pci(e) host mode
From: Rafał Miłecki <zajec5@gmail.com>
Date: Mon, 6 Jun 2011 13:34:15 +0200
Cc: linux-wireless@vger.kernel.org, linux-mips@linux-mips.org, mb@bu3sch.de, george@znau.edu.ua, arend@broadcom.com, b43-dev@lists.infradead.org, bernhardloos@googlemail.com
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=T3uuQdTY6x1mI1O0cDc0jqZ+uLB7Wb0PB89Q5fluNtI=; b=hA3+nirSdFYIZoQ05xkmpD/0+lDcvFLPoXm0PMkf6fCE4OQgfstim4WjHHqDO3rxkU YHjFtH/hp4WJBswuX0z1WmIojp852PKXX6gK3dyWIwm0/Nzmbp1PWjv348o8FqrI5+Hn rzuvBgjHv1KdwuRybDb1TYCPQxSu+Ysr1Eq7M=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=gCbb4G+IEesLcl8LJllr8pfHYO8lGowvq1SYnVUepe2bF50ynHq6q3dhiFX4XcRk82 913/GyE6x1DOuggJKk2iO9/4Zs1XpwTbk87Pqx2I9PM7/Ff08GUyVrg+zsNPuZJDDPDS IztArznGhIIW9H/F57B6HCG0MbNSOPDsEs2Rw=
In-reply-to: <1307311658-15853-8-git-send-email-hauke@hauke-m.de>
References: <1307311658-15853-1-git-send-email-hauke@hauke-m.de> <1307311658-15853-8-git-send-email-hauke@hauke-m.de>
Sender: linux-mips-bounce@linux-mips.org
2011/6/6 Hauke Mehrtens <hauke@hauke-m.de>:
> +#ifdef CONFIG_BCMA_PCICORE_HOSTMODE
> +/* driver_pci_host.c */
> +extern int bcma_pcicore_is_in_hostmode(struct bcma_drv_pci *pc);
> +extern void bcma_pcicore_init_hostmode(struct bcma_drv_pci *pc);
> +#endif /* CONFIG_BCMA_PCICORE_HOSTMODE */

I don't know if I'm overreacting, but I really don't like naming mess
in the ssb.

Why don't you use bcma_core_pci_* to be consistent?

-- 
Rafał

<Prev in Thread] Current Thread [Next in Thread>