linux-mips
[Top] [All Lists]

Re: [RFC][PATCH 03/10] bcma: add embedded bus

To: Arend van Spriel <arend@broadcom.com>
Subject: Re: [RFC][PATCH 03/10] bcma: add embedded bus
From: Rafał Miłecki <zajec5@gmail.com>
Date: Mon, 6 Jun 2011 13:00:29 +0200
Cc: George Kashperko <george@znau.edu.ua>, Hauke Mehrtens <hauke@hauke-m.de>, "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>, "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>, "mb@bu3sch.de" <mb@bu3sch.de>, "b43-dev@lists.infradead.org" <b43-dev@lists.infradead.org>, "bernhardloos@googlemail.com" <bernhardloos@googlemail.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=g3a68JGgAoCoxXg8BlCkX4SRBq/EDK7rMpFLEzJHblI=; b=rrbDtHFJcGp+HFB9tLvXEFPYHhrFKonU6aFFQdxhY8sL5cbKH57uMRyE50XyGjJez2 UtylmCKhuW5S3dkl73MswIR4I0eTa0v4qr4lr7vHxmsDH2SGrIIWjDKE7GaPz5hF01Ol IOi2PQlTVOLBpsSj0V1/MF8XJQhQqVAWAiP5g=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=hLcUwJHvUxgu/vCOx2gei21yzCnxGGfOgSls/BaRqzlGmNRRvjEwPY+o5ZkHIJg92c TJyIimDdR9GoxuwiX1vcz5xY2i+NQHZKi8Y0PboIZbPlbg519i+lmoT1xbERMg/JuKOi BcStGymhhBHn5UciQGvPYbn5LKs6PElI0hrUU=
In-reply-to: <4DECB232.70308@broadcom.com>
References: <1307311658-15853-1-git-send-email-hauke@hauke-m.de> <1307311658-15853-4-git-send-email-hauke@hauke-m.de> <BANLkTi=T6xO9q+vOCk5Fu+2J_nUTwX3dcg@mail.gmail.com> <1307356322.28734.11.camel@dev.znau.edu.ua> <BANLkTimkKFAEfbKaWo81=uyuDS=gjESHAw@mail.gmail.com> <4DECB232.70308@broadcom.com>
Sender: linux-mips-bounce@linux-mips.org
W dniu 6 czerwca 2011 12:55 użytkownik Arend van Spriel
<arend@broadcom.com> napisał:
> On 06/06/2011 12:51 PM, Rafał Miłecki wrote:
>>
>> W dniu 6 czerwca 2011 12:32 użytkownik George Kashperko
>> <george@znau.edu.ua>  napisał:
>>>
>>> Hi,
>>>
>>>> Hauke,
>>>>
>>>> My idea for naming schema was to use:
>>>> bcma_host_TYPE_*
>>>>
>>>> Like:
>>>> bcma_host_pci_*
>>>> bcma_host_sdio_*
>>>>
>>>> You are using:
>>>> bcma_host_bcma_*
>>>>
>>>> What do you think about changing this to:
>>>> bcma_host_embedded_*
>>>> or just some:
>>>> bcma_host_emb_*
>>>> ?
>>>>
>>>> Does it make more sense to you? I was trying to keep names in bcma
>>>> really clear, so every first-time-reader can see differences between
>>>> hosts, host and driver, etc.
>>>
>>> how about bcma_host_soc ?
>>
>> We get then inconsistency with "BCMA_HOSTTYPE_EMBEDDED". I'd like to
>> 1) See something like bcma_host_emb...
>> xor
>> 2) Use bcma_host_soc_* and BCMA_HOSTTYPE_SOC
>>
>
> I would go for option 2). It more clearly says what it is. Embedded is a
> broader term. As an example, a handset is an embedded device, but it may use
> BCMA_HOSTTYPE_SDIO.

Good point, agree.

-- 
Rafał

<Prev in Thread] Current Thread [Next in Thread>