linux-mips
[Top] [All Lists]

Re: [RFC][PATCH 05/10] bcma: add serial console support

To: Hauke Mehrtens <hauke@hauke-m.de>
Subject: Re: [RFC][PATCH 05/10] bcma: add serial console support
From: Rafał Miłecki <zajec5@gmail.com>
Date: Mon, 6 Jun 2011 12:30:49 +0200
Cc: linux-wireless@vger.kernel.org, linux-mips@linux-mips.org, mb@bu3sch.de, george@znau.edu.ua, arend@broadcom.com, b43-dev@lists.infradead.org, bernhardloos@googlemail.com
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=pcMMdg0LSRQ33MJb9iCduXTENE8D3psZWZN0JJDtVlM=; b=wgdoAXYGGOhyiiavE/mDMGeZE0QI/3evr6FT+AD0CGfQEq/tcNijsCGpRjBxovvHk4 LSVxSaH1FW3exRh55H8knv2YsVLZqvtA4bnrfT9hERd174QYbYPuOh4zTc/fOlHqUzmJ tpb3Wm+CyJ3rCZEmbLQaGG4ToH6tvNe0JPSv8=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=hdErGTt5yMSljZVtAVBDqSo77sY0ZK4cPhu1s4hSI3/YccXRVx2qod9CnYSLVqLhVD WUPA0LX19/qkdLeOQrzKM3kZAEgJ4EbCPZ+ASv4Y91b/BKV1vT5d8ZU8p4Wq4p8X49bJ eS+AjBBoxcbEWHltUJF3J6q+mHki519Qnbs2k=
In-reply-to: <1307311658-15853-6-git-send-email-hauke@hauke-m.de>
References: <1307311658-15853-1-git-send-email-hauke@hauke-m.de> <1307311658-15853-6-git-send-email-hauke@hauke-m.de>
Sender: linux-mips-bounce@linux-mips.org
2011/6/6 Hauke Mehrtens <hauke@hauke-m.de>:
> +       if ((ccrev >= 11) && (ccrev != 15) && (ccrev != 20)) {
> +       ....
> +       } else
> +               pr_err("serial not supported on this device ccrev: 0x%x\n",
> +                      ccrev);

Please use scripts/checkpatch* for your patches. I believe it will
alert you about lacking brackets for "else" (kernel coding style).

-- 
Rafał

<Prev in Thread] Current Thread [Next in Thread>