linux-mips
[Top] [All Lists]

RE: patch to support topdown mmap allocation in MIPS

To: "David Daney" <ddaney@caviumnetworks.com>
Subject: RE: patch to support topdown mmap allocation in MIPS
From: "Jian Peng" <jipeng@broadcom.com>
Date: Wed, 25 May 2011 11:06:44 -0700
Accept-language: en-US
Acceptlanguage: en-US
Cc: "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>, "Ralf Baechle" <ralf@linux-mips.org>
In-reply-to: <4DDD432D.4020200@caviumnetworks.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <E18F441196CA634DB8E1F1C56A50A8743242B54C8A@IRVEXCHCCR01.corp.ad.broadcom.com> <4DD1BD72.2000408@caviumnetworks.com> <E18F441196CA634DB8E1F1C56A50A8743242B54D97@IRVEXCHCCR01.corp.ad.broadcom.com> <4DD2A729.9090502@caviumnetworks.com> <E18F441196CA634DB8E1F1C56A50A8743242B54FA7@IRVEXCHCCR01.corp.ad.broadcom.com> <E18F441196CA634DB8E1F1C56A50A874572CCBB6B5@IRVEXCHCCR01.corp.ad.broadcom.com> <4DDD432D.4020200@caviumnetworks.com>
Sender: linux-mips-bounce@linux-mips.org
Thread-index: AcwbBVcOuMe2pbjkS7u+cbhp1RyQVgAABI5w
Thread-topic: patch to support topdown mmap allocation in MIPS
Hi, David,

I am willing to get more feedback and sort out issues before I forgot all 
details.

I post a simple testing program at 
http://www.linux-mips.org/archives/linux-mips/2011-05/msg00252.html
And it was also tested in a real application using mmap heavily and need this 
patch to avoid failure.

It is my bad to take your suggestion literally. How about 
arch_get_unmapped_area_common()?

Thanks,
Jian

-----Original Message-----
From: David Daney [mailto:ddaney@caviumnetworks.com] 
Sent: Wednesday, May 25, 2011 10:58 AM
To: Jian Peng
Cc: linux-mips@linux-mips.org; Ralf Baechle
Subject: Re: patch to support topdown mmap allocation in MIPS

On 05/25/2011 10:47 AM, Jian Peng wrote:
> Hi, Ralf/David,
>
> What else should I do to get this patch merged?
>

Be patient.  And tell how it was tested.


Also ....

[...]
> +
> +unsigned long arch_get_unmapped_area_foo(struct file *filp, unsigned long 
> addr0,
> +               unsigned long len, unsigned long pgoff, unsigned long flags,
> +               enum mmap_allocation_direction dir)

I know I suggested the name *_foo, but really I expected you to choose a 
better name, as the 'foo' is just the default name for examples.

I think it needs a better name than that.

I will try to test it on my Octeon system sometime.

David Daney



<Prev in Thread] Current Thread [Next in Thread>