linux-mips
[Top] [All Lists]

Re: patch to support topdown mmap allocation in MIPS

To: Jian Peng <jipeng@broadcom.com>
Subject: Re: patch to support topdown mmap allocation in MIPS
From: David Daney <ddaney@caviumnetworks.com>
Date: Wed, 25 May 2011 10:58:05 -0700
Cc: "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>, Ralf Baechle <ralf@linux-mips.org>
In-reply-to: <E18F441196CA634DB8E1F1C56A50A874572CCBB6B5@IRVEXCHCCR01.corp.ad.broadcom.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <E18F441196CA634DB8E1F1C56A50A8743242B54C8A@IRVEXCHCCR01.corp.ad.broadcom.com> <4DD1BD72.2000408@caviumnetworks.com> <E18F441196CA634DB8E1F1C56A50A8743242B54D97@IRVEXCHCCR01.corp.ad.broadcom.com> <4DD2A729.9090502@caviumnetworks.com> <E18F441196CA634DB8E1F1C56A50A8743242B54FA7@IRVEXCHCCR01.corp.ad.broadcom.com> <E18F441196CA634DB8E1F1C56A50A874572CCBB6B5@IRVEXCHCCR01.corp.ad.broadcom.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10
On 05/25/2011 10:47 AM, Jian Peng wrote:
Hi, Ralf/David,

What else should I do to get this patch merged?


Be patient.  And tell how it was tested.


Also ....

[...]
+
+unsigned long arch_get_unmapped_area_foo(struct file *filp, unsigned long 
addr0,
+               unsigned long len, unsigned long pgoff, unsigned long flags,
+               enum mmap_allocation_direction dir)

I know I suggested the name *_foo, but really I expected you to choose a better name, as the 'foo' is just the default name for examples.

I think it needs a better name than that.

I will try to test it on my Octeon system sometime.

David Daney

<Prev in Thread] Current Thread [Next in Thread>