linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS:i8259.c remove resume and shutdown to syscore_ops

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] MIPS:i8259.c remove resume and shutdown to syscore_ops
From: Thomas Gleixner <tglx@linutronix.de>
Date: Tue, 24 May 2011 16:01:43 +0200 (CEST)
Cc: Pengfei Zhang <zoppof.zhang@gmail.com>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
In-reply-to: <20110524135940.GA30117@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1306239558-4997-1-git-send-email-zoppof.zhang@gmail.com> <20110524135940.GA30117@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Alpine 2.02 (LFD 1266 2009-07-14)
On Tue, 24 May 2011, Ralf Baechle wrote:

> On Tue, May 24, 2011 at 08:19:18PM +0800, Pengfei Zhang wrote:
> 
> > Remove the resume and shutdown of i8259A from the sysdev_class
> > to the syscore_ops since these members had removed from the
> > structure sysdev_class.
> 
> I don't see why one would want to want to first call register_syscore_ops
> then sysdev_class_register and sysdev_register?

The whole point of syscore_ops is to get rid of the sysdev which had
only one purpose: handing the suspend/resume ops in. The resulting
sysfs entry is completely useless.

Thanks,

        tglx

<Prev in Thread] Current Thread [Next in Thread>