linux-mips
[Top] [All Lists]

Re: [PATCH 0/2] MIPS: oprofile: callgraph support

To: Gergely Kis <gergely@homejinni.com>, Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH 0/2] MIPS: oprofile: callgraph support
From: Robert Richter <robert.richter@amd.com>
Date: Tue, 24 May 2011 10:42:50 +0200
Cc: "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>, Daniel Kalmar <kalmard@homejinni.com>, "oprofile-list@lists.sourceforge.net" <oprofile-list@lists.sourceforge.net>
In-reply-to: <1305290285-13818-1-git-send-email-gergely@homejinni.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1305290285-13818-1-git-send-email-gergely@homejinni.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On 13.05.11 08:38:03, Gergely Kis wrote:
> From: Daniel Kalmar <kalmard@homejinni.com>
> 
> These patches add callgraph/backtrace support to oprofile on MIPS.
> 
> Stack unwinding is done by code examination. For kernelspace, the
> already existing unwind function is utilized that uses kallsyms to
> quickly find the beginning of functions. For userspace a new function
> was added that examines code at and before the pc.
> 
> Daniel Kalmar (2):
>   MIPS: Add unwind_stack_by_address to support unwinding from any
>     kernel code address
>   MIPS: oprofile: Add callgraph support
> 
>  arch/mips/include/asm/stacktrace.h |    4 +
>  arch/mips/kernel/process.c         |   18 +++-
>  arch/mips/oprofile/Makefile        |    2 +-
>  arch/mips/oprofile/backtrace.c     |  173 
> ++++++++++++++++++++++++++++++++++++
>  arch/mips/oprofile/common.c        |    1 +
>  arch/mips/oprofile/op_impl.h       |    2 +
>  6 files changed, 194 insertions(+), 6 deletions(-)
>  create mode 100644 arch/mips/oprofile/backtrace.c

Daniel and Gergely,

the patches look good so far. I fixed the coding style to have the
opening brace of functions at the beginning of the next line. After
the MIPS maintainer's ack I will apply them to the oprofile tree.

Thanks for your contribution.

Ralf,

please ack.

Thanks,

-Robert

-- 
Advanced Micro Devices, Inc.
Operating System Research Center


<Prev in Thread] Current Thread [Next in Thread>