Re: reference to non-existent CONFIG_HAVE_GPIO_LIB variable?

[Florian Fainelli <florian@openwrt.org>]

Hello,

On Monday 16 May 2011 11:36:46 Robert P. J. Day wrote:
> On Mon, 16 May 2011, Florian Fainelli wrote:
> > Hello,
> > 
> > On Sunday 15 May 2011 01:05:58 Robert P. J. Day wrote:
> > >   the current kernel source contains a Makefile reference to the above
> > > 
> > > Kconfig variable that does not appear to be defined anywhere.
> > 
> > It would help if you mention which Makefile references this Kconfig
> > variable along with the changeset which introduced it.
> 
>   quite so, my bad.  here's the changeset:

Thank you. I think the author rather meant ARCH_WANT_OPTIONAL_GPIOLIB instead, 
can you build test a patch with this and submit it if you are happy with it?

> 
> $ git show 9fa32c6b
> commit 9fa32c6b0275ab1e8b19f74fbfa3ed8411345db6
> Author: Patrick Glass <patrickglass@gmail.com>
> Date:   Mon Aug 18 14:41:30 2008 -0700
> 
>     MIPS: PMC MSP71XX gpio drivers
> 
>     This new gpio driver for PMC-Sierra's MSP71xx SoC allows
>     standard api calls for access to the general and extended
>     gpio's.
> 
>     Signed-off-by: Patrick Glass <patrickglass@gmail.com>
>     Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
> 
>      create mode 100755 arch/mips/pmc-sierra/msp71xx/gpio.c
>      create mode 100755 arch/mips/pmc-sierra/msp71xx/gpio_extended.c
>      create mode 100755 include/asm-mips/pmc-sierra/msp71xx/gpio.h
> 
> diff --git a/arch/mips/pmc-sierra/msp71xx/Makefile
> b/arch/mips/pmc-sierra/msp71xx/Make
> index 4bba79c..e107f79 100644
> --- a/arch/mips/pmc-sierra/msp71xx/Makefile
> +++ b/arch/mips/pmc-sierra/msp71xx/Makefile
> @@ -3,6 +3,7 @@
>  #
>  obj-y += msp_prom.o msp_setup.o msp_irq.o \
>          msp_time.o msp_serial.o msp_elb.o
> +obj-$(CONFIG_HAVE_GPIO_LIB) += gpio.o gpio_extended.o
>  obj-$(CONFIG_PMC_MSP7120_GW) += msp_hwbutton.o
>  obj-$(CONFIG_IRQ_MSP_SLP) += msp_irq_slp.o
>  obj-$(CONFIG_IRQ_MSP_CIC) += msp_irq_cic.o
> ... etc etc ...
> 
>   but there is no Kconfig file that defines the HAVE_GPIO_LIB variable
> that i can see.
> 
> rday