linux-mips
[Top] [All Lists]

Re: reference to non-existent CONFIG_HAVE_GPIO_LIB variable?

To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Subject: Re: reference to non-existent CONFIG_HAVE_GPIO_LIB variable?
From: Florian Fainelli <florian@openwrt.org>
Date: Mon, 16 May 2011 13:33:20 +0200
Cc: linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:from:organization:to:subject:date :user-agent:cc:references:in-reply-to:mime-version:content-type :content-transfer-encoding:message-id; bh=ZVVcnNZ69qHM4MQegNgwmpTPvW9uoORG88mXf4bgPRs=; b=mBI5mYKK9cs9vkPXEUJireUhIdnHAo9wuruVJ7OfUndHXrjBK+bof0ZTOlLNWwiwl5 oi/qOHKHwGEY7xJDFsteNFFF3WR5bsaSEuJZVtvLs1Np/byF9Pi9TatYKOXKuq6KffLE 1Mzvk85so8n//b9W0/dCJ2S6OSanDXTSk9jZI=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:organization:to:subject:date:user-agent:cc:references :in-reply-to:mime-version:content-type:content-transfer-encoding :message-id; b=q8jeWvyqeSZbG7BIYMqHx2LL3pAjVNWUMvmZYyxwjYaQovQt1hD1erDPk/O6fg2y9L 5BkV5s6up2nmLxLBTrYUSJeFYhB47BvU0pRBWDHDZ9t1FpzgYF3pcGUkk5YgQt/Z6yUT 0wFXeHSZ36tGfO0X/N1GrIcYxV/eaL0FYn210=
In-reply-to: <alpine.DEB.2.00.1105160533590.7414@localhost6.localdomain6>
Organization: OpenWrt
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <alpine.DEB.2.00.1105141904410.13343@localhost6.localdomain6> <201105161023.33072.florian@openwrt.org> <alpine.DEB.2.00.1105160533590.7414@localhost6.localdomain6>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/1.13.6 (Linux/2.6.38-8-server; KDE/4.6.2; x86_64; ; )
Hello,

On Monday 16 May 2011 11:36:46 Robert P. J. Day wrote:
> On Mon, 16 May 2011, Florian Fainelli wrote:
> > Hello,
> > 
> > On Sunday 15 May 2011 01:05:58 Robert P. J. Day wrote:
> > >   the current kernel source contains a Makefile reference to the above
> > > 
> > > Kconfig variable that does not appear to be defined anywhere.
> > 
> > It would help if you mention which Makefile references this Kconfig
> > variable along with the changeset which introduced it.
> 
>   quite so, my bad.  here's the changeset:

Thank you. I think the author rather meant ARCH_WANT_OPTIONAL_GPIOLIB instead, 
can you build test a patch with this and submit it if you are happy with it?

> 
> $ git show 9fa32c6b
> commit 9fa32c6b0275ab1e8b19f74fbfa3ed8411345db6
> Author: Patrick Glass <patrickglass@gmail.com>
> Date:   Mon Aug 18 14:41:30 2008 -0700
> 
>     MIPS: PMC MSP71XX gpio drivers
> 
>     This new gpio driver for PMC-Sierra's MSP71xx SoC allows
>     standard api calls for access to the general and extended
>     gpio's.
> 
>     Signed-off-by: Patrick Glass <patrickglass@gmail.com>
>     Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
> 
>      create mode 100755 arch/mips/pmc-sierra/msp71xx/gpio.c
>      create mode 100755 arch/mips/pmc-sierra/msp71xx/gpio_extended.c
>      create mode 100755 include/asm-mips/pmc-sierra/msp71xx/gpio.h
> 
> diff --git a/arch/mips/pmc-sierra/msp71xx/Makefile
> b/arch/mips/pmc-sierra/msp71xx/Make
> index 4bba79c..e107f79 100644
> --- a/arch/mips/pmc-sierra/msp71xx/Makefile
> +++ b/arch/mips/pmc-sierra/msp71xx/Makefile
> @@ -3,6 +3,7 @@
>  #
>  obj-y += msp_prom.o msp_setup.o msp_irq.o \
>          msp_time.o msp_serial.o msp_elb.o
> +obj-$(CONFIG_HAVE_GPIO_LIB) += gpio.o gpio_extended.o
>  obj-$(CONFIG_PMC_MSP7120_GW) += msp_hwbutton.o
>  obj-$(CONFIG_IRQ_MSP_SLP) += msp_irq_slp.o
>  obj-$(CONFIG_IRQ_MSP_CIC) += msp_irq_cic.o
> ... etc etc ...
> 
>   but there is no Kconfig file that defines the HAVE_GPIO_LIB variable
> that i can see.
> 
> rday

<Prev in Thread] Current Thread [Next in Thread>