linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: AR7: Fix GCC 4.6.0 build error.

To: Alexander Clouter <alex@digriz.org.uk>
Subject: Re: [PATCH] MIPS: AR7: Fix GCC 4.6.0 build error.
From: Jonas Gorski <jonas.gorski+openwrt@gmail.com>
Date: Fri, 13 May 2011 18:20:51 +0200
Cc: linux-mips@linux-mips.org, florian@openwrt.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:from :date:x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=s/l/zcuCEpQ1P+oWGDhPrms+zWvO88WLBEz6RYEwbL8=; b=bDd7XAcFL95OSPdNil/rgZnD2qbDsDCsquyM74l7eOxk5JeVkIwnSTB4Xf+dIUwYXi ZDTS0Gg6ZNGt7Semm1x5RAJof3Zh+x92wxFfmEIuOAzssvuNcR2rlxgY8p0j8eVci6EW 5uEI9rYEY8MFkVZiL/KSfO7oEk87uY9Nfn6Pw=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; b=q2TYJHX7ShKFE8K7RJCZ0H2QPAnc7O/Qs3pUG/GDJvTwl0XQr/rE9wU+zad6uozMu1 evWMdT2q9+3cr8vQvgau547290lUPmIPRmw+OEdcDPjH/n1Muo+Xj9jFQl1AvBspFKHX tITHMHdI9b1moBD47bXVb5l9LORueIb6nyRww=
In-reply-to: <20110513152855.GM25017@chipmunk>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20110513152855.GM25017@chipmunk>
Sender: linux-mips-bounce@linux-mips.org
On 13 May 2011 17:28, Alexander Clouter <alex@digriz.org.uk> wrote:
>  CC      arch/mips/ar7/gpio.o
> arch/mips/ar7/gpio.c: In function 'ar7_gpio_init':
> arch/mips/ar7/gpio.c:318:11: error: variable 'size' set but not used 
> [-Werror=unused-but-set-variable]
> cc1: all warnings being treated as errors
>
> Signed-off-by: Alexander Clouter <alex@digriz.org.uk>
> ---
>  arch/mips/ar7/gpio.c |   12 ++----------
>  1 files changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/arch/mips/ar7/gpio.c b/arch/mips/ar7/gpio.c
> index 425dfa5..6917427 100644
> --- a/arch/mips/ar7/gpio.c
> +++ b/arch/mips/ar7/gpio.c
> @@ -314,16 +314,8 @@ static void titan_gpio_init(void)
>  int __init ar7_gpio_init(void)
>  {
>        int ret;
> -       struct ar7_gpio_chip *gpch;
> -       unsigned size;
> -
> -       if (!ar7_is_titan()) {
> -               gpch = &ar7_gpio_chip;
> -               size = 0x10;
> -       } else {
> -               gpch = &titan_gpio_chip;
> -               size = 0x1f;
> -       }
> +       struct ar7_gpio_chip *gpch = (!ar7_is_titan())
> +               ? &ar7_gpio_chip : &titan_gpio_chip;
>
>        gpch->regs = ioremap_nocache(AR7_REGS_GPIO,
>                                        AR7_REGS_GPIO + 0x10);

Without any AR7 knowledge, it looks like the size is supposed to be
used here instead of the 0x10 - also the "AR7_REGS_GPIO + 0x10" looks
wrong - I don't think the regs are 0x8610910 bytes big ;-).

Regards
Jonas

<Prev in Thread] Current Thread [Next in Thread>