linux-mips
[Top] [All Lists]

Re: [PATCH 1/4] MIPS: Replace _PAGE_READ with _PAGE_NO_READ

To: Kevin Cernekee <cernekee@gmail.com>
Subject: Re: [PATCH 1/4] MIPS: Replace _PAGE_READ with _PAGE_NO_READ
From: Ralf Baechle <ralf@linux-mips.org>
Date: Fri, 13 May 2011 16:07:07 +0100
Cc: David Daney <ddaney@caviumnetworks.com>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
In-reply-to: <7aa38c32b7748a95e814e5bb0583f967@localhost>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <7aa38c32b7748a95e814e5bb0583f967@localhost>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Sat, Apr 16, 2011 at 09:44:29AM -0700, Kevin Cernekee wrote:

> Reuse more of the same definitions for the non-RIXI and RIXI cases.  This
> avoids having special cases for kernel_uses_smartmips_rixi cluttering up
> the pgtable*.h files.
> 
> On hardware that does not support RI/XI, EntryLo bits 31:30 / 63:62 will
> remain unset and RI/XI permissions will not be enforced.

Nice idea but it breaks on 64-bit hardware running 32-bit kernels.  On
those the RI/XI bits written to c0_entrylo0/1 31:30 will be interpreted as
physical address bits 37:36.

I'm removing this patch series from the 2.6.40 patch queue until we can
sort this out.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>