linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Squash pci_fixup_irqs() compiler warning

To: David Daney <ddaney.cavm@gmail.com>
Subject: Re: [PATCH] MIPS: Squash pci_fixup_irqs() compiler warning
From: Ralf Baechle <ralf@linux-mips.org>
Date: Fri, 13 May 2011 11:17:16 +0100
Cc: Kevin Cernekee <cernekee@gmail.com>, Wu Zhangjin <wuzhangjin@gmail.com>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
In-reply-to: <4DAC7499.5000602@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <cb01d61712b1374a8c62bc765094ea7e@localhost> <4DAC7499.5000602@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Apr 18, 2011 at 10:27:53AM -0700, David Daney wrote:

> >It's been two years since the original discussion, and the warning is
> >still there.  It is now the only warning left in my kernel build.
> >
> >I was hoping we could get this resolved for good (one way or another).

[...]

> NAK.
> 
> I think Ralf's idea in the e-mail you referenced is the proper approach.
> 
> Change pci_fixup_irqs(...) to take a 'const struct pci_dev *'
> instead. There is a lot of work going on in the kernel to constify
> things.  This should be fairly easy to get accepted.

It's a fairly big manual job but should be just right for spatch.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>