linux-mips
[Top] [All Lists]

Re: [PATCH 1/3] MIPS: lantiq: Add missing include to mach-easy50712.c

To: John Crispin <blogic@openwrt.org>
Subject: Re: [PATCH 1/3] MIPS: lantiq: Add missing include to mach-easy50712.c
From: David Daney <ddaney@caviumnetworks.com>
Date: Thu, 12 May 2011 10:09:36 -0700
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
In-reply-to: <4DCB76E5.3070703@openwrt.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1305145347-32605-1-git-send-email-ddaney@caviumnetworks.com> <1305145347-32605-2-git-send-email-ddaney@caviumnetworks.com> <20110511212538.GB17315@linux-mips.org> <4DCB76E5.3070703@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10
On 05/11/2011 10:57 PM, John Crispin wrote:
On 11/05/11 23:25, Ralf Baechle wrote:
Thanks, folded into "MIPS: Lantiq: Add etop board support".

   Ralf



Hi,

the include should be in arch/lantiq/devices.h and not the mach-*.c file.


It is best to keep the include pushed as far to the leaves of the build as possible. That makes compiling other files that need devices.h faster.

this got lost int he folding and i thought we fixed it yesterday already .

In any event I think Ralf has it sorted out now. linux-queue is now building for me with no patches.

David Daney

<Prev in Thread] Current Thread [Next in Thread>