linux-mips
[Top] [All Lists]

Re: [PATCH] atomic: add *_dec_not_zero

To: "Russell King - ARM Linux" <linux@arm.linux.org.uk>
Subject: Re: [PATCH] atomic: add *_dec_not_zero
From: Sven Eckelmann <sven@narfation.org>
Date: Sun, 8 May 2011 11:33:48 +0200
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mips@linux-mips.org, linux-m32r@ml.linux-m32r.org, linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org, linux-cris-kernel@axis.com, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, x86@kernel.org, Chris Metcalf <cmetcalf@tilera.com>, David Howells <dhowells@redhat.com>, linux-m68k@lists.linux-m68k.org, linux-am33-list@redhat.com, linux-alpha@vger.kernel.org, sparclinux@vger.kernel.org, uclinux-dist-devel@blackfin.uclinux.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org
Dkim-signature: v=1; a=rsa-sha256; c=simple/simple; d=narfation.org; s=mail; t=1304847247; bh=ZsDp5I2ahHMgchtif3vZZU35EkCa+97w9vNVwQ5M3xA=; h=From:To:Subject:Date:Cc:References:In-Reply-To:MIME-Version: Content-Type:Content-Transfer-Encoding:Message-Id; b=UUW1EBfLxJNFvY/LDh8PBm8rGCZKtQvto51iZFwmd/nCE61DgW1bc0WMiUiJXJX9m /Lvq69R/oWN9CGVqFmqfpq8AoTUoP5yxfkdJ3SaXbNFEnNoBuSjeG3Iyced9l5r+oo GZ9D0K4j7Cx4IHK5bti3bLQwSBcoZ3B40M7iNn8o=
In-reply-to: <20110508092403.GB27807@n2100.arm.linux.org.uk>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1304458235-28473-1-git-send-email-sven@narfation.org> <20110508092403.GB27807@n2100.arm.linux.org.uk>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/1.13.7 (Linux/2.6.38-2-amd64; KDE/4.6.2; x86_64; ; )
Russell King - ARM Linux wrote:
[...]
> Do we need atomic_dec_not_zero() et.al. in every arch header - is there no
> generic header which it could be added to?

Mike Frysinger already tried to answer it in 
<BANLkTimctgbto3dsnJ3d3r7NggS0KF9_Sw@mail.gmail.com>:
> that's what asm-generic is for.  if the arch isnt using it, it's
> either because the arch needs to convert to it, or they're using SMP
> and asm-generic doesnt yet support that for atomic.h.
>
> for example, the Blackfin port only needed updating for the SMP case.
> in the non-SMP case, we're getting the def from asm-generic/atomic.h.
> -mike

Feel free to change that but I just followed the style used by all other 
macros and will not redesign the complete atomic*.h idea.

thanks,
        Sven

Attachment: signature.asc
Description: This is a digitally signed message part.

<Prev in Thread] Current Thread [Next in Thread>