linux-mips
[Top] [All Lists]

Re: [RFC PATCH v3 1/6] of: Allow scripts/dtc/libfdt to be used from kern

To: Michal Marek <mmarek@suse.cz>
Subject: Re: [RFC PATCH v3 1/6] of: Allow scripts/dtc/libfdt to be used from kernel code
From: David Daney <ddaney@caviumnetworks.com>
Date: Fri, 06 May 2011 10:14:26 -0700
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, devicetree-discuss@lists.ozlabs.org, grant.likely@secretlab.ca, linux-kernel@vger.kernel.org
In-reply-to: <4DC3D3D5.6060007@suse.cz>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1304614949-30460-1-git-send-email-ddaney@caviumnetworks.com> <1304614949-30460-2-git-send-email-ddaney@caviumnetworks.com> <4DC3D3D5.6060007@suse.cz>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10
On 05/06/2011 03:56 AM, Michal Marek wrote:
On 5.5.2011 19:02, David Daney wrote:
--- /dev/null
+++ b/drivers/of/libfdt/Makefile
@@ -0,0 +1,8 @@
+ccflags-y := -include linux/libfdt_env.h
-I$(src)/../../../scripts/dtc/libfdt
+
+obj-y = fdt.o fdt_wip.o fdt_ro.o
+
+
+$(obj)/%.o: $(src)/../../../scripts/dtc/libfdt/%.c FORCE
+ $(call cmd,force_checksrc)
+ $(call if_changed_rule,cc_o_c)

It's just three source files, so you could use three one-line wrappers
that #include ../../../scripts/dtc/libfdt/<file>.c instead of copying
the %.c -> %.o rule here.


Good idea, that does seem cleaner.

I will adjust the patch.

David Daney

<Prev in Thread] Current Thread [Next in Thread>