linux-mips
[Top] [All Lists]

Re: [PATCH] USB: OHCI: Fix build warning on Alchemy

To: Greg KH <gregkh@suse.de>
Subject: Re: [PATCH] USB: OHCI: Fix build warning on Alchemy
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 14 Apr 2011 02:31:24 +0200
Cc: linux-usb@vger.kernel.org, Manuel Lauss <manuel.lauss@googlemail.com>, linux-mips@linux-mips.org
In-reply-to: <20110413234317.GB17342@suse.de>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20110413232308.GA22925@linux-mips.org> <20110413234317.GB17342@suse.de>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Apr 13, 2011 at 04:43:17PM -0700, Greg KH wrote:

> On Thu, Apr 14, 2011 at 01:23:08AM +0200, Ralf Baechle wrote:
> >   CC      drivers/usb/host/ohci-hcd.o
> > In file included from drivers/usb/host/ohci-hcd.c:1028:0:
> > drivers/usb/host/ohci-au1xxx.c:36:7: warning: "__BIG_ENDIAN" is not defined 
> > [-Wundef]
> > 
> > Fix the warning and some other build bullet proofing; let's not rely on
> > other needed header files getting dragged in magically.
> 
> Ick, I just applied the second part of this patch to my "for-linus"
> tree as a patch from someone else.  Are the #include changes really
> needed right now?

No, the include stuff was more for paranoia.

However the warning fixed by the 2nd part of the patch exists back to
at least 2.6.27.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>