linux-mips
[Top] [All Lists]

Re: [PATCH 2/3] MIPS: lantiq: add ethernet driver

To: John Crispin <blogic@openwrt.org>
Subject: Re: [PATCH 2/3] MIPS: lantiq: add ethernet driver
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Tue, 12 Apr 2011 16:54:24 -0700
Cc: Ralf Baechle <ralf@linux-mips.org>, Ralph Hempel <ralph.hempel@lantiq.com>, linux-mips@linux-mips.org, netdev@vger.kernel.org
In-reply-to: <1302624675-18652-3-git-send-email-blogic@openwrt.org>
Organization: Vyatta
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1302624675-18652-1-git-send-email-blogic@openwrt.org> <1302624675-18652-3-git-send-email-blogic@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
On Tue, 12 Apr 2011 18:11:14 +0200
John Crispin <blogic@openwrt.org> wrote:

> +
> +struct ltq_mii_priv {
> +     struct ltq_eth_data *pldata;
> +     struct resource *res;
> +     struct net_device_stats stats;

You don't need to have private stats structure it is part
of net_device in recent kernels. In fact, since you don't
set .ndo_get_stats, the driver is getting the default function
which prints the values from network_device, not your priv structure.

Also, please consider adding basic ethtool support to
show speed/duplex and driver information.

-- 

<Prev in Thread] Current Thread [Next in Thread>