linux-mips
[Top] [All Lists]

Re: [RFC 3/5]arch:mips:pmc-sierra:msp71xx:Makefile Remove unused config

To: "Justin P. Mattock" <justinmattock@gmail.com>
Subject: Re: [RFC 3/5]arch:mips:pmc-sierra:msp71xx:Makefile Remove unused config in the Makefile.
From: Ralf Baechle <ralf@linux-mips.org>
Date: Fri, 8 Apr 2011 15:08:11 +0200
Cc: trivial@kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org
In-reply-to: <1302022702-24541-3-git-send-email-justinmattock@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1302022702-24541-1-git-send-email-justinmattock@gmail.com> <1302022702-24541-3-git-send-email-justinmattock@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Apr 05, 2011 at 09:58:20AM -0700, Justin P. Mattock wrote:

> The patch below removes an unused config variable found by using a kernel
> cleanup script.
> Note: I did try to cross compile these but hit erros while doing so..
> (gcc is not setup to cross compile) and am unsure if anymore needs to be done.
> Please have a look if/when anybody has free time.

NACK.

This need a rewrite, not just chainsawing.  Your code was only touching
the makefile anyway, not the two referenced C files.

 Ralf

  Ralf

<Prev in Thread] Current Thread [Next in Thread>