linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: bcm63xx: Fix header_crc comment in bcm963xx_tag.h

To: Jonas Gorski <jonas.gorski@gmail.com>
Subject: Re: [PATCH] MIPS: bcm63xx: Fix header_crc comment in bcm963xx_tag.h
From: Florian Fainelli <florian@openwrt.org>
Date: Fri, 8 Apr 2011 14:41:30 +0200
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:from:organization:to:subject:date :user-agent:cc:references:in-reply-to:mime-version:content-type :content-transfer-encoding:message-id; bh=2nvSnqx0enimr9pGiLCUl1i+BdkguSTaNu5KUZ36thQ=; b=YSyGXsADVTCpRsPm7EyQvJ4081dqk5L6ibKFcJr3y989HsC97McHvQJpmCBvUdd7hW q8v6Ko1gSceEdmK8KwSQSXh+i8SrL5aJQXp9ZxVFAwQ/9xO1+OIUjYlZJN9N1LvMNTm2 pZlStcSJwPJ+pHOjqjafhcZIrDjeUVOiSaOIk=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:organization:to:subject:date:user-agent:cc:references :in-reply-to:mime-version:content-type:content-transfer-encoding :message-id; b=mDQFevq80qdlFEfPVp217B7RbR2wlnOnjUwQQAp+6ZuT8WrTBbvxeDotbu5yVBrvk9 Mdn5VENfFKUHJQaCbK7TOo6STPma/yCpePmkpfR1/04zF+8NFampUAhOY3NoeK3kLpY0 Wb4KbYdkscoFIl6siIabB/sui6dlKTzczSKz4=
In-reply-to: <1302265935-23802-1-git-send-email-jonas.gorski@gmail.com>
Organization: OpenWrt
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1302265935-23802-1-git-send-email-jonas.gorski@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/1.13.5 (Linux/2.6.35-25-server; KDE/4.5.1; x86_64; ; )
On Friday 08 April 2011 14:32:15 Jonas Gorski wrote:
> The CRC32 actually includes the tag_version.
> 
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>

Acked-by: Florian Fainelli <florian@openwrt.org>

> ---
> 
> This was already wrong in the original Broadcom sources (and it still
> seems to be).
> 
>  arch/mips/include/asm/mach-bcm63xx/bcm963xx_tag.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/mips/include/asm/mach-bcm63xx/bcm963xx_tag.h
> b/arch/mips/include/asm/mach-bcm63xx/bcm963xx_tag.h index 5325084..73c499f
> 100644
> --- a/arch/mips/include/asm/mach-bcm63xx/bcm963xx_tag.h
> +++ b/arch/mips/include/asm/mach-bcm63xx/bcm963xx_tag.h
> @@ -88,7 +88,7 @@ struct bcm_tag {
>       char kernel_crc[CRC_LEN];
>       /* 228-235: Unused at present */
>       char reserved1[8];
> -     /* 236-239: CRC32 of header excluding tagVersion */
> +     /* 236-239: CRC32 of header excluding last 20 bytes */
>       char header_crc[CRC_LEN];
>       /* 240-255: Unused at present */
>       char reserved2[16];

<Prev in Thread] Current Thread [Next in Thread>