linux-mips
[Top] [All Lists]

Re: [PATCH V6] MIPS: lantiq: add NOR flash support

To: John Crispin <blogic@openwrt.org>
Subject: Re: [PATCH V6] MIPS: lantiq: add NOR flash support
From: Artem Bityutskiy <dedekind1@gmail.com>
Date: Tue, 05 Apr 2011 15:15:51 +0300
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, Ralph Hempel <ralph.hempel@lantiq.com>, linux-mtd@lists.infradead.org, Daniel Schwierzeck <daniel.schwierzeck@googlemail.com>, David Woodhouse <dwmw2@infradead.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:subject:from:reply-to:to:cc:in-reply-to :references:content-type:date:message-id:mime-version:x-mailer :content-transfer-encoding; bh=RGHgL3kQDTp2+D+kmn3Zx/UboP5IlQeXckXgKk3Lv0M=; b=r+wsWTwCJEhGHzHGnmZZLx5GvPji8stZj4aIFw0NSLk/mMuetvfvf/x/TncdJQ3FII bC1pS0zBvcqtvAe6McSn/S9N5V6v638p4NFH74qORevGQmjArj29MhbUQC5uUFSkcueb xB/ar+3Z4Dy+4vCcRPKAsy4ERdyufoirwJja0=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:reply-to:to:cc:in-reply-to:references:content-type :date:message-id:mime-version:x-mailer:content-transfer-encoding; b=Bwn3AwzjlxWHeYc9mR23Gdfo4HoSPkdhD4UCMk/41sERd/PZNjLoUV1mUXeOaHi9Un oYdXe/40Blt1jsebkJhjoUHLSbhClEdQuIXsfLbyvyrOPygRaTqdqsGo2ZiCqbbZ8S7o L6IThc94dbOQdyAYUitwQu6wWXpm9JC14brWY=
In-reply-to: <1302005720-8508-1-git-send-email-blogic@openwrt.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1302005720-8508-1-git-send-email-blogic@openwrt.org>
Reply-to: dedekind1@gmail.com
Sender: linux-mips-bounce@linux-mips.org
On Tue, 2011-04-05 at 14:15 +0200, John Crispin wrote:
> +int __init
> +init_ltq_mtd(void)
> +{
> +     int ret = platform_driver_probe(&ltq_mtd_driver, ltq_mtd_probe);
> +
> +     if (ret)
> +             pr_err(KERN_INFO "ltq_nor: error registering platfom driver");

Sorry, but pr_err is defined as follows:

#define pr_err(fmt, ...) \
        printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)

You should not add KERN_INFO.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)


<Prev in Thread] Current Thread [Next in Thread>