linux-mips
[Top] [All Lists]

Re: [PATCH V5 06/10] MIPS: lantiq: add NOR flash support

To: dedekind1@gmail.com
Subject: Re: [PATCH V5 06/10] MIPS: lantiq: add NOR flash support
From: John Crispin <blogic@openwrt.org>
Date: Mon, 04 Apr 2011 15:36:52 +0200
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, Ralph Hempel <ralph.hempel@lantiq.com>, linux-mtd@lists.infradead.org, Daniel Schwierzeck <daniel.schwierzeck@googlemail.com>, David Woodhouse <dwmw2@infradead.org>
In-reply-to: <1301661832.2789.56.camel@localhost>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1301470076-17279-1-git-send-email-blogic@openwrt.org> <1301470076-17279-7-git-send-email-blogic@openwrt.org> <1301661832.2789.56.camel@localhost>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.12) Gecko/20100913 Icedove/3.0.7
Hi Artem

thanks for the feedback, comments inline
>
>> +ltq_copy_from(struct map_info *map, void *to,
>> +    unsigned long from, ssize_t len)
>> +{
>> +    unsigned char *f = (unsigned char *) (map->virt + from);
>> +    unsigned char *t = (unsigned char *) to;
>> +    unsigned long flags;
>> +
>> +    spin_lock_irqsave(&ebu_lock, flags);
>> +    while (len--)
>> +            *t++ = *f++;
>> +    spin_unlock_irqrestore(&ebu_lock, flags);
>>     
> Can you use memcpy here instead?
>
>   

as we are copying to/from iomem, we cannot use memcpy as the
pre-fetching breaks the copy process. the normal alternative is to use
memcpy_to/fromio, however on MIPS this breaks down to a normal memcpy.

i will fold your comments into the patch and resend it ASAP

thanks, John

<Prev in Thread] Current Thread [Next in Thread>