linux-mips
[Top] [All Lists]

Re: kmemleak for MIPS

To: Maxin John <maxin.john@gmail.com>
Subject: Re: kmemleak for MIPS
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 30 Mar 2011 15:27:02 +0200
Cc: Daniel Baluta <daniel.baluta@gmail.com>, Catalin Marinas <catalin.marinas@arm.com>, naveen yadav <yad.naveen@gmail.com>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:subject:from:to:cc:in-reply-to:references :content-type:date:message-id:mime-version:x-mailer :content-transfer-encoding; bh=9Whpb+jr3K5vRStH0msL3OZ8fN1/ipv2YDMvo2V2rHo=; b=pvQ98CrGwwdSeOsuEjdSIi/olHEg2S7bQ9eKqA9yCPUe1Qkz+HLyxZw/GS4EjRpG5h A+ujv75tvkM9ZRF0MkBn6R5XarJN4L+YPsnGDIRF0+EbPskYymKljO3Gb0rPhTeGcoLO zAtPrgxQQ6irmJuiGSnsjFj/NYG/jLy35sTp4=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:x-mailer:content-transfer-encoding; b=ljm7lq+SaRsk00gWyTBpsGbXpY0aAl3XVF+2teTz4DRC+vJqJhq8t45S5G5/b/7jZs f/EbR+Z7pE11EZYruGqzX8Q2AnGx4hz3DE1uajx1MvCpc0yI+rtH+pcfW93pga+XBPg/ bAzHYwobcAP3Rd3fMtDB+XEZA5BKsf8eq4MHY=
In-reply-to: <AANLkTi=RXoEOVmTPiL=dfO97aOVKWOJWE7hoQduPPsCZ@mail.gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <9bde694e1003020554p7c8ff3c2o4ae7cb5d501d1ab9@mail.gmail.com> <AANLkTinnqtXf5DE+qxkTyZ9p9Mb8dXai6UxWP2HaHY3D@mail.gmail.com> <1300960540.32158.13.camel@e102109-lin.cambridge.arm.com> <AANLkTim139fpJsMJFLiyUYvFgGMz-Ljgd_yDrks-tqhE@mail.gmail.com> <1301395206.583.53.camel@e102109-lin.cambridge.arm.com> <AANLkTim-4v5Cbp6+wHoXjgKXoS0axk1cgQ5AHF_zot80@mail.gmail.com> <1301399454.583.66.camel@e102109-lin.cambridge.arm.com> <AANLkTin0_gT0E3=oGyfMwk+1quqonYBExeN9a3=v=Lob@mail.gmail.com> <AANLkTi=gMP6jQuQFovfsOX=7p-SSnwXoVLO_DVEpV63h@mail.gmail.com> <1301476505.29074.47.camel@e102109-lin.cambridge.arm.com> <AANLkTi=YB+nBG7BYuuU+rB9TC-BbWcJ6mVfkxq0iUype@mail.gmail.com> <AANLkTi=L0zqwQ869khH1efFUghGeJjoyTaBXs-O2icaM@mail.gmail.com> <AANLkTi=vcn5jHpk0O8XS9XJ8s5k-mCnzUwu70mFTx4=g@mail.gmail.com> <1301485085.29074.61.camel@e102109-lin.cambridge.arm.com> <AANLkTikXfVNkyFE2MpW9ZtfX2G=QKvT7kvEuDE-YE5xO@mail.gmail.com> <1301488032.3283.42.camel@edumazet-laptop> <AANLkTikX0jxdkyYgPoqjvC5HzY8VydTbFh_gFDzM8zJ7@mail.gmail.com> <AANLkTi=RXoEOVmTPiL=dfO97aOVKWOJWE7hoQduPPsCZ@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
Le mercredi 30 mars 2011 à 14:17 +0100, Maxin John a écrit :
> Hi,
> 
> I have compiled the kernel with below given modification in .config
> 
> CONFIG_CMDLINE="uhash_entries=256"
> 
> After booting with the new kernel, the "kmemleak" no longer complains
> about the "udp_table_init".
> However it do report another possible leak :)
> 
> debian-mips:~# cat /sys/kernel/debug/kmemleak
> unreferenced object 0x8f085000 (size 4096):
>   comm "swapper", pid 1, jiffies 4294937670 (age 1043.280s)
>   hex dump (first 32 bytes):
>     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
>     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
>   backtrace:
>     [<801ac7a8>] __kmalloc+0x130/0x180
>     [<80532500>] flow_cache_cpu_prepare+0x50/0xa8
>     [<8052378c>] flow_cache_init_global+0x90/0x138
>     [<80100584>] do_one_initcall+0x174/0x1e0
>     [<8050c348>] kernel_init+0xe4/0x174
>     [<80103d4c>] kernel_thread_helper+0x10/0x18
> debian-mips:~#

Hmm, then MIPS kmemleak port might have a problem with percpu data ?

fcp->hash_table = kzalloc_node(sz, GFP_KERNEL, cpu_to_node(cpu));

fcp is a per cpu "struct flow_cache_percpu"

> I completely agree with Daniel. Shall we move on and integrate the
> kmemleak support for MIPS ?



<Prev in Thread] Current Thread [Next in Thread>