linux-mips
[Top] [All Lists]

Re: kmemleak for MIPS

To: Maxin John <maxin.john@gmail.com>
Subject: Re: kmemleak for MIPS
From: Catalin Marinas <catalin.marinas@arm.com>
Date: Wed, 30 Mar 2011 10:15:05 +0100
Cc: Daniel Baluta <dbaluta@ixiacom.com>, naveen yadav <yad.naveen@gmail.com>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org
In-reply-to: <AANLkTi=gMP6jQuQFovfsOX=7p-SSnwXoVLO_DVEpV63h@mail.gmail.com>
Organization: ARM Limited
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <9bde694e1003020554p7c8ff3c2o4ae7cb5d501d1ab9@mail.gmail.com> <AANLkTinnqtXf5DE+qxkTyZ9p9Mb8dXai6UxWP2HaHY3D@mail.gmail.com> <1300960540.32158.13.camel@e102109-lin.cambridge.arm.com> <AANLkTim139fpJsMJFLiyUYvFgGMz-Ljgd_yDrks-tqhE@mail.gmail.com> <1301395206.583.53.camel@e102109-lin.cambridge.arm.com> <AANLkTim-4v5Cbp6+wHoXjgKXoS0axk1cgQ5AHF_zot80@mail.gmail.com> <1301399454.583.66.camel@e102109-lin.cambridge.arm.com> <AANLkTin0_gT0E3=oGyfMwk+1quqonYBExeN9a3=v=Lob@mail.gmail.com> <AANLkTi=gMP6jQuQFovfsOX=7p-SSnwXoVLO_DVEpV63h@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
On Tue, 2011-03-29 at 20:36 +0100, Maxin John wrote:
> I have prepared the combined patch for kmemleak porting to MIPS. After
> applying the patch and enabling the kmemleak in Kernel, I can see one
> kernel memleak reported during booting itself:
...
> unreferenced object 0x8f90d000 (size 4096):
>   comm "swapper", pid 1, jiffies 4294937330 (age 815.000s)
>   hex dump (first 32 bytes):
>     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
>     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
>   backtrace:
>     [<80529644>] alloc_large_system_hash+0x2f8/0x410
>     [<805383b4>] udp_table_init+0x4c/0x158
>     [<805384dc>] udp_init+0x1c/0x94
>     [<8053889c>] inet_init+0x184/0x2a0
>     [<80100584>] do_one_initcall+0x174/0x1e0
>     [<8051f348>] kernel_init+0xe4/0x174
>     [<80103d4c>] kernel_thread_helper+0x10/0x18

If you for the kmemleak scan (via echo) a few times, do you get more
leaks? The udp_table_init() function looks like it could leak some
memory but I haven't seen it before. I'm not sure whether this is a
false positive or a real leak.
> 
> Please let me know your comments.
> 
> Signed-off-by: Maxin B. John <maxin.john@gmail.com>
> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>

I think the last line should be more like:

Acked-by: Catalin Marinas <catalin.marinas@arm.com>



<Prev in Thread] Current Thread [Next in Thread>