On 07/03/11 13:25, John Crispin wrote:
> On 07/03/11 09:58, Artem Bityutskiy wrote:
>> On Tue, 2011-03-01 at 17:13 +0100, John Crispin wrote:
>>> NOR flash is attached to the same EBU (External Bus Unit) as PCI. As
>>> in the PCI patch, the EBU is a little buggy, resulting in the upper and
>>> 16 bit of the data on a 32 bit read are swapped. (essentially we have a
>>> To work around this we do a addr^=2 during the probe. Once probed we adapt
>>> cfi->addr_unlock1 and cfi->addr_unlock2 to represent the endianess bug.
>>> Changes in V2
>>> * handle the endianess bug inside the map code and not in the generic cfi
>>> * remove the addr swizzle patch
>>> Signed-off-by: John Crispin <firstname.lastname@example.org>
>>> Signed-off-by: Ralph Hempel <email@example.com>
>>> Cc: David Woodhouse <firstname.lastname@example.org>
>>> Cc: Daniel Schwierzeck <email@example.com>
>>> Cc: firstname.lastname@example.org
>>> Cc: email@example.com
>> There are a couple checkpatch.pl warnings, would you please address them
>> and resend?
> of course.
i fixed one of the warnings. the remaining warning wants me to put at
least 4 lines into the help section in the Kconfig. However 3 lines were
enough to explain what the driver does.