linux-mips
[Top] [All Lists]

Re: [PATCH v3 1/4] genirq: Reserve the irq when calling irq_set_chip()

To: David Daney <ddaney@caviumnetworks.com>
Subject: Re: [PATCH v3 1/4] genirq: Reserve the irq when calling irq_set_chip()
From: Thomas Gleixner <tglx@linutronix.de>
Date: Fri, 25 Mar 2011 23:30:04 +0100 (CET)
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, linux-kernel@vger.kernel.org
In-reply-to: <1301081931-11240-2-git-send-email-ddaney@caviumnetworks.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1301081931-11240-1-git-send-email-ddaney@caviumnetworks.com> <1301081931-11240-2-git-send-email-ddaney@caviumnetworks.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Alpine 2.00 (LFD 1167 2008-08-23)
On Fri, 25 Mar 2011, David Daney wrote:

> The helper macros and functions like for_each_active_irq() don't work
> unless the irq is in the allocated_irqs set.
> 
> In the case of !CONFIG_SPARSE_IRQ, instead of forcing all users of the
> irq infrastructure to explicitly call irq_reserve_irq(), do it for
> them.
> 
> Signed-off-by: David Daney <ddaney@caviumnetworks.com>
> ---
>  kernel/irq/chip.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
> index c9c0601..54d9aab 100644
> --- a/kernel/irq/chip.c
> +++ b/kernel/irq/chip.c
> @@ -37,6 +37,12 @@ int irq_set_chip(unsigned int irq, struct irq_chip *chip)
>       irq_chip_set_defaults(chip);
>       desc->irq_data.chip = chip;
>       irq_put_desc_unlock(desc, flags);
> +     /*
> +      * For !CONFIG_SPARSE_IRQ make the irq show up in
> +      * allocated_irqs.  For the CONFIG_SPARSE_IRQ case, it may
> +      * already be there, and this call is harmless.

For SPARSE=y it _IS_ already there, otherwise we would not reach that
code.

> +      */
> +     irq_reserve_irq(irq);
>       return 0;
>  }
>  EXPORT_SYMBOL(irq_set_chip);
> -- 
> 1.7.2.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

<Prev in Thread] Current Thread [Next in Thread>