linux-mips
[Top] [All Lists]

Re: [PATCH 1/7] Netlogic XLR/XLS processor IDs.

To: Sergei Shtylyov <sshtylyov@mvista.com>
Subject: Re: [PATCH 1/7] Netlogic XLR/XLS processor IDs.
From: Ralf Baechle <ralf@linux-mips.org>
Date: Fri, 25 Mar 2011 13:58:20 +0100
Cc: Jayachandran C <jayachandranc@netlogicmicro.com>, linux-mips@linux-mips.org
In-reply-to: <4D8C7C01.9080107@mvista.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <cover.1301028080.git.jayachandranc@netlogicmicro.com> <bf492d3d03640f86bdd9963d892545423567451d.1301028081.git.jayachandranc@netlogicmicro.com> <4D8C7C01.9080107@mvista.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Mar 25, 2011 at 02:26:57PM +0300, Sergei Shtylyov wrote:

> >+static inline void cpu_probe_netlogic(struct cpuinfo_mips *c, int cpu)
> >+{
> >+    decode_configs(c);
> >+
> >+    c->options = (MIPS_CPU_TLB     |
> 
>    Perhaps should align | with others...
> 
> >+                    MIPS_CPU_4KEX    |
> >+                    MIPS_CPU_COUNTER |
> >+                    MIPS_CPU_DIVEC   |
> >+                    MIPS_CPU_WATCH   |
> >+                    MIPS_CPU_EJTAG   |
> >+                    MIPS_CPU_LLSC);

I reformatted that.

> [...]
> >+    default:
> >+            printk(KERN_INFO "Unknown Netlogic chip id [%02x]!\n",
> 
>    Not %04x?

I changed this into a panic call.  An unknown CPU type means very little
chance for the system to actually succesfully boot the system.

Queued for 2.6.39.  Thanks,

  Ralf

<Prev in Thread] Current Thread [Next in Thread>