linux-mips
[Top] [All Lists]

Re: [patch 06/38] mips: dec: Convert to new irq_chip functions

To: "Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: [patch 06/38] mips: dec: Convert to new irq_chip functions
From: Thomas Gleixner <tglx@linutronix.de>
Date: Thu, 24 Mar 2011 20:29:48 +0100 (CET)
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
In-reply-to: <alpine.LFD.2.00.1103241808300.18858@eddie.linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20110323210437.398062704@linutronix.de> <20110323210535.149703003@linutronix.de> <20110324141815.GG30990@linux-mips.org> <alpine.LFD.2.00.1103241513140.18858@eddie.linux-mips.org> <alpine.LFD.2.00.1103241709430.31464@localhost6.localdomain6> <alpine.LFD.2.00.1103241808300.18858@eddie.linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Alpine 2.00 (LFD 1167 2008-08-23)
On Thu, 24 Mar 2011, Maciej W. Rozycki wrote:
> On Thu, 24 Mar 2011, Thomas Gleixner wrote:
> > So the .ack pointer is filled with ack_ioasic_irq, right ?
> 
>  The ack used to be made in clear_ioasic_irq(), that was called from 
> end_ioasic_dma_irq(), that was used as the .end handler.  This semantics 
> has to be preserved or hardware won't work anymore as expected.  This is a 
> regression.

Then that code was broken before. Since MIPS was converted to the flow
handlers nothing ever called .end(). I seem to miss something.

Thanks,

        tglx

<Prev in Thread] Current Thread [Next in Thread>