Re: [patch 06/38] mips: dec: Convert to new irq

To:	"Maciej W. Rozycki" <macro@linux-mips.org>
Subject:	Re: [patch 06/38] mips: dec: Convert to new irq_chip functions
From:	Thomas Gleixner <tglx@linutronix.de>
Date:	Thu, 24 Mar 2011 20:29:48 +0100 (CET)
Cc:	Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
In-reply-to:	<alpine.LFD.2.00.1103241808300.18858@eddie.linux-mips.org>
Original-recipient:	rfc822;linux-mips@linux-mips.org
References:	<20110323210437.398062704@linutronix.de> <20110323210535.149703003@linutronix.de> <20110324141815.GG30990@linux-mips.org> <alpine.LFD.2.00.1103241513140.18858@eddie.linux-mips.org> <alpine.LFD.2.00.1103241709430.31464@localhost6.localdomain6> <alpine.LFD.2.00.1103241808300.18858@eddie.linux-mips.org>
Sender:	linux-mips-bounce@linux-mips.org
User-agent:	Alpine 2.00 (LFD 1167 2008-08-23)

On Thu, 24 Mar 2011, Maciej W. Rozycki wrote:
> On Thu, 24 Mar 2011, Thomas Gleixner wrote:
> > So the .ack pointer is filled with ack_ioasic_irq, right ?
> 
>  The ack used to be made in clear_ioasic_irq(), that was called from 
> end_ioasic_dma_irq(), that was used as the .end handler.  This semantics 
> has to be preserved or hardware won't work anymore as expected.  This is a 
> regression.

Then that code was broken before. Since MIPS was converted to the flow
handlers nothing ever called .end(). I seem to miss something.

Thanks,

        tglx

<Prev in Thread]	Current Thread	[Next in Thread>
[patch 04/38] mips: bcm63xx: Convert to new irq_chip functions, (continued) [patch 04/38] mips: bcm63xx: Convert to new irq_chip functions, Thomas Gleixner Re: [patch 04/38] mips: bcm63xx: Convert to new irq_chip functions, Ralf Baechle [patch 05/38] mips: cavium-octeon: Convert to new irq_chip functions, Thomas Gleixner Re: [patch 05/38] mips: cavium-octeon: Convert to new irq_chip functions, David Daney Re: [patch 05/38] mips: cavium-octeon: Convert to new irq_chip functions, Ralf Baechle [patch 06/38] mips: dec: Convert to new irq_chip functions, Thomas Gleixner Re: [patch 06/38] mips: dec: Convert to new irq_chip functions, Ralf Baechle Re: [patch 06/38] mips: dec: Convert to new irq_chip functions, Maciej W. Rozycki Re: [patch 06/38] mips: dec: Convert to new irq_chip functions, Thomas Gleixner Re: [patch 06/38] mips: dec: Convert to new irq_chip functions, Maciej W. Rozycki Re: [patch 06/38] mips: dec: Convert to new irq_chip functions, Thomas Gleixner <= Re: [patch 06/38] mips: dec: Convert to new irq_chip functions, Maciej W. Rozycki Re: [patch 06/38] mips: dec: Convert to new irq_chip functions, Atsushi Nemoto Re: [patch 06/38] mips: dec: Convert to new irq_chip functions, Maciej W. Rozycki [patch 07/38] mips: emma: Convert to new irq_chip functions, Thomas Gleixner Re: [patch 07/38] mips: emma: Convert to new irq_chip functions, Ralf Baechle [patch 08/38] mips: jazz: Convert to new irq_chip functions, Thomas Gleixner Re: [patch 08/38] mips: jazz: Convert to new irq_chip functions, Ralf Baechle [patch 09/38] MIPS: JZ4740: Convert to new irq functions, Thomas Gleixner Re: [patch 09/38] MIPS: JZ4740: Convert to new irq functions, Ralf Baechle [patch 10/38] MIPS: JZ4740: GPIO: Use shared irq chip for all gpios, Thomas Gleixner

Previous by Date:	Re: [patch 06/38] mips: dec: Convert to new irq_chip functions, Maciej W. Rozycki
Next by Date:	Re: [trivial PATCH 1/2] treewide: Fix iomap resource size miscalculations, Ralf Baechle
Previous by Thread:	Re: [patch 06/38] mips: dec: Convert to new irq_chip functions, Maciej W. Rozycki
Next by Thread:	Re: [patch 06/38] mips: dec: Convert to new irq_chip functions, Maciej W. Rozycki
Indexes:	[Date] [Thread] [Top] [All Lists]

Re: [patch 06/38] mips: dec: Convert to new irq_chip functions