linux-mips
[Top] [All Lists]

Re: [patch 06/38] mips: dec: Convert to new irq_chip functions

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [patch 06/38] mips: dec: Convert to new irq_chip functions
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Thu, 24 Mar 2011 15:21:04 +0000 (GMT)
Cc: Thomas Gleixner <tglx@linutronix.de>, linux-mips@linux-mips.org
In-reply-to: <20110324141815.GG30990@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20110323210437.398062704@linutronix.de> <20110323210535.149703003@linutronix.de> <20110324141815.GG30990@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Alpine 2.00 (LFD 1167 2008-08-23)
On Thu, 24 Mar 2011, Ralf Baechle wrote:

> Thanks, queued for 2.6.39.

 Ralf, thanks for cc-ing me.

 NACK, where's the logic to ack IOASIC DMA IRQs gone?  The SIR has to be 
written as in clear_ioasic_irq() for the respective DMA transfer to resume 
and the interrupt in question be able to retrigger in the future.

 The rest is probably OK, but why has the inline hint been removed?  
These functions are simple, worth a couple of assembly instructions at 
most and used throughout these files, so it's good to ask GCC to inline 
them if worthwhile even if -fno-unit-at-a-time has been requested for 
whatever reason.

  Maciej

<Prev in Thread] Current Thread [Next in Thread>