| To: | Sergei Shtylyov <sshtylyov@mvista.com> |
|---|---|
| Subject: | Re: [patch 37/38] mips: vr41xx: Cleanup the direct access to irq_desc[] |
| From: | Thomas Gleixner <tglx@linutronix.de> |
| Date: | Thu, 24 Mar 2011 15:21:12 +0100 (CET) |
| Cc: | linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org> |
| In-reply-to: | <4D8B4D8E.1010000@mvista.com> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <20110323210437.398062704@linutronix.de> <20110323210538.070462971@linutronix.de> <4D8B3CBC.3080307@mvista.com> <alpine.LFD.2.00.1103241400250.31464@localhost6.localdomain6> <4D8B4D8E.1010000@mvista.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Alpine 2.00 (LFD 1167 2008-08-23) |
On Thu, 24 Mar 2011, Sergei Shtylyov wrote: > Hello. > > On 24-03-2011 16:00, Thomas Gleixner wrote: > > > > > - if (!(desc->status& IRQ_DISABLED)&& > > > > desc->chip->unmask) > > > > - desc->chip->unmask(source_irq); > > > > + if (!(desc->status& IRQ_DISABLED)&& > > > > chip->irq_unmask) > > > > + chip->irq_unmask(idata); > > > > Hm, doesn't this (I mean the old) code break after the previous patch? > > > Not as long as the compat functions are active in the core. > > I've looked at compat_*() before replying: it seems that they work vice > versa, i.e. the new functions are emulated by calling the old, and you're > moving away from old to new in the previous patch. Maybe I miss something... Oops. Yes. So the patches should be folded |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [patch 09/38] MIPS: JZ4740: Convert to new irq functions, Ralf Baechle |
|---|---|
| Next by Date: | Re: [patch 10/38] MIPS: JZ4740: GPIO: Use shared irq chip for all gpios, Ralf Baechle |
| Previous by Thread: | Re: [patch 37/38] mips: vr41xx: Cleanup the direct access to irq_desc[], Sergei Shtylyov |
| Next by Thread: | Re: [patch 37/38] mips: vr41xx: Cleanup the direct access to irq_desc[], Ralf Baechle |
| Indexes: | [Date] [Thread] [Top] [All Lists] |