linux-mips
[Top] [All Lists]

Re: [patch 37/38] mips: vr41xx: Cleanup the direct access to irq_desc[]

To: Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [patch 37/38] mips: vr41xx: Cleanup the direct access to irq_desc[]
From: Sergei Shtylyov <sshtylyov@mvista.com>
Date: Thu, 24 Mar 2011 16:56:30 +0300
Cc: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>
In-reply-to: <alpine.LFD.2.00.1103241400250.31464@localhost6.localdomain6>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20110323210437.398062704@linutronix.de> <20110323210538.070462971@linutronix.de> <4D8B3CBC.3080307@mvista.com> <alpine.LFD.2.00.1103241400250.31464@localhost6.localdomain6>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.2.15) Gecko/20110303 Thunderbird/3.1.9
Hello.

On 24-03-2011 16:00, Thomas Gleixner wrote:

-               if (!(desc->status&   IRQ_DISABLED)&&   desc->chip->unmask)
-                       desc->chip->unmask(source_irq);
+               if (!(desc->status&   IRQ_DISABLED)&&   chip->irq_unmask)
+                       chip->irq_unmask(idata);

    Hm, doesn't this (I mean the old) code break after the previous patch?

Not as long as the compat functions are active in the core.

I've looked at compat_*() before replying: it seems that they work vice versa, i.e. the new functions are emulated by calling the old, and you're moving away from old to new in the previous patch. Maybe I miss something...

WBR, Sergei

<Prev in Thread] Current Thread [Next in Thread>