Re: [patch 37/38] mips: vr41xx: Cleanup the direct access to irq

To:	Sergei Shtylyov <sshtylyov@mvista.com>
Subject:	Re: [patch 37/38] mips: vr41xx: Cleanup the direct access to irq_desc[]
From:	Thomas Gleixner <tglx@linutronix.de>
Date:	Thu, 24 Mar 2011 14:00:53 +0100 (CET)
Cc:	linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>
In-reply-to:	<4D8B3CBC.3080307@mvista.com>
Original-recipient:	rfc822;linux-mips@linux-mips.org
References:	<20110323210437.398062704@linutronix.de> <20110323210538.070462971@linutronix.de> <4D8B3CBC.3080307@mvista.com>
Sender:	linux-mips-bounce@linux-mips.org
User-agent:	Alpine 2.00 (LFD 1167 2008-08-23)

On Thu, 24 Mar 2011, Sergei Shtylyov wrote:
> > -           if (!(desc->status&  IRQ_DISABLED)&&  desc->chip->unmask)
> > -                   desc->chip->unmask(source_irq);
> > +           if (!(desc->status&  IRQ_DISABLED)&&  chip->irq_unmask)
> > +                   chip->irq_unmask(idata);
> 
>    Hm, doesn't this (I mean the old) code break after the previous patch?

Not as long as the compat functions are active in the core.

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [patch 33/38] mips: sybyte: Convert to new irq_chip functions, (continued) Re: [patch 33/38] mips: sybyte: Convert to new irq_chip functions, Ralf Baechle [patch 34/38] mips: sni: Convert to new irq_chip functions, Thomas Gleixner Re: [patch 34/38] mips: sni: Convert to new irq_chip functions, Ralf Baechle [patch 35/38] mips: txx9: Convert to new irq_chip functions, Thomas Gleixner Re: [patch 35/38] mips: txx9: Convert to new irq_chip functions, Ralf Baechle [patch 36/38] mips: vr41: Convert to new irq_chip functions, Thomas Gleixner Re: [patch 36/38] mips: vr41: Convert to new irq_chip functions, Sergei Shtylyov Re: [patch 36/38] mips: vr41: Convert to new irq_chip functions, Ralf Baechle [patch 37/38] mips: vr41xx: Cleanup the direct access to irq_desc[], Thomas Gleixner Re: [patch 37/38] mips: vr41xx: Cleanup the direct access to irq_desc[], Sergei Shtylyov Re: [patch 37/38] mips: vr41xx: Cleanup the direct access to irq_desc[], Thomas Gleixner <= Re: [patch 37/38] mips: vr41xx: Cleanup the direct access to irq_desc[], Sergei Shtylyov Re: [patch 37/38] mips: vr41xx: Cleanup the direct access to irq_desc[], Thomas Gleixner Re: [patch 37/38] mips: vr41xx: Cleanup the direct access to irq_desc[], Ralf Baechle [patch 38/38] mips: Select GENERIC_HARDIRQS_NO_DEPRECATED, Thomas Gleixner Re: [patch 38/38] mips: Select GENERIC_HARDIRQS_NO_DEPRECATED, Ralf Baechle

Previous by Date:	Re: [patch 10/38] MIPS: JZ4740: GPIO: Use shared irq chip for all gpios, Thomas Gleixner
Next by Date:	Re: [patch 37/38] mips: vr41xx: Cleanup the direct access to irq_desc[], Sergei Shtylyov
Previous by Thread:	Re: [patch 37/38] mips: vr41xx: Cleanup the direct access to irq_desc[], Sergei Shtylyov
Next by Thread:	Re: [patch 37/38] mips: vr41xx: Cleanup the direct access to irq_desc[], Sergei Shtylyov
Indexes:	[Date] [Thread] [Top] [All Lists]

Re: [patch 37/38] mips: vr41xx: Cleanup the direct access to irq_desc[]