linux-mips
[Top] [All Lists]

Re: [patch 10/38] MIPS: JZ4740: GPIO: Use shared irq chip for all gpios

To: Sergei Shtylyov <sshtylyov@mvista.com>
Subject: Re: [patch 10/38] MIPS: JZ4740: GPIO: Use shared irq chip for all gpios
From: Thomas Gleixner <tglx@linutronix.de>
Date: Thu, 24 Mar 2011 13:59:12 +0100 (CET)
Cc: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>, Lars-Peter Clausen <lars@metafoo.de>
In-reply-to: <4D8B35DA.6020804@mvista.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20110323210437.398062704@linutronix.de> <20110323210535.525705907@linutronix.de> <4D8B35DA.6020804@mvista.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Alpine 2.00 (LFD 1167 2008-08-23)
On Thu, 24 Mar 2011, Sergei Shtylyov wrote:

> Hello.
> 
> On 24-03-2011 0:08, Thomas Gleixner wrote:
> 
> > Currently there is one irq_chip per gpio_chip with the only difference
> > being the name. Since the information whether the irq belong to GPIO
> > bank A, B, C or D is not that important rewrite the code to simply use
> > a single irq_chip for all gpio_chips.
> 
> > Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> 
>    If these 2 patches are from Lars, shouldn't there be "From: Lars-Peter
> Clausen <lars@metafoo.de>" line at the start of the patches?

Yep. Mangled that, sorry.

<Prev in Thread] Current Thread [Next in Thread>