linux-mips
[Top] [All Lists]

Re: [patch 01/38] mips; Convert alchemy to new irq chip functions

To: Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [patch 01/38] mips; Convert alchemy to new irq chip functions
From: Manuel Lauss <manuel.lauss@googlemail.com>
Date: Thu, 24 Mar 2011 08:41:56 +0100
Cc: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=E3I4ml9vtM1INtAatwlgUe5Q8kG4zTO6VPBX2qwMq+w=; b=DAjlQs6Ofm5hQDcqJTWvZ/6vRMHBjRf1YR+m8HOoH1M7VrTN+QvQYeSnTn8jXtwwh/ U61pYf9DsbZTEAvX35JhMj4AW9pCgQ7Cfw4w5S4XO5QWfw0gVyym8oIdi2bKeEnoreql 7K5TlN3cC2lGBubdV1sgvf9WV1dEY7sCsbVtE=
Domainkey-signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=RzViNRi00xFqyarmBY9N1vqMujXuTvAlZstSdXuT/WFB80WQmmaf6mDTF7sP3xi5bL 0/4V/QL6a5EaJINEVepccUtYV+W1kKJhd6iMB85eGCwq+44pt2sjVYc7P/1/QpR9xq+R k1k/NwOGoSTmFfA9TDC05EfoFuX0U0qIFuslQ=
In-reply-to: <20110323210534.669706549@linutronix.de>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20110323210437.398062704@linutronix.de> <20110323210534.669706549@linutronix.de>
Sender: linux-mips-bounce@linux-mips.org
On Wed, Mar 23, 2011 at 10:08 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> Fix the deadlock in set_type() while at it.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
>  arch/mips/alchemy/common/irq.c     |   98 
> ++++++++++++++++++-------------------
>  arch/mips/alchemy/devboards/bcsr.c |   18 +++---
>  2 files changed, 59 insertions(+), 57 deletions(-)

Tested on the db1200, works fine.

I'm curious though: could you please elaborate on where the deadlock came from?
Is it not safe to call set_irq_type() at all times?

Thanks!
        Manuel Lauss

<Prev in Thread] Current Thread [Next in Thread>