linux-mips
[Top] [All Lists]

Re: [PATCH 3/7] Add XLR/XLS cache and TLB support

To: David Daney <ddaney@caviumnetworks.com>
Subject: Re: [PATCH 3/7] Add XLR/XLS cache and TLB support
From: "Jayachandran C." <jayachandranc@netlogicmicro.com>
Date: Wed, 16 Mar 2011 22:52:33 +0530
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
In-reply-to: <4D80EA02.9030605@caviumnetworks.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <cover.1300275485.git.jayachandranc@netlogicmicro.com> <cadf7ed67683e96d920fedc87d8fc5d6dbdccdc7.1300275485.git.jayachandranc@netlogicmicro.com> <4D80EA02.9030605@caviumnetworks.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, Mar 16, 2011 at 09:49:06AM -0700, David Daney wrote:
> On 03/16/2011 04:57 AM, Jayachandran C wrote:
> [...]
> >diff --git a/arch/mips/include/asm/mach-netlogic/cpu-feature-overrides.h 
> >b/arch/mips/include/asm/mach-netlogic/cpu-feature-overrides.h
> >new file mode 100644
> >index 0000000..7740401
> >--- /dev/null
> >+++ b/arch/mips/include/asm/mach-netlogic/cpu-feature-overrides.h
> >@@ -0,0 +1,9 @@
> >+#ifndef __ASM_MACH_NETLOGIC_CPU_FEATURE_OVERRIDES_H
> >+#define __ASM_MACH_NETLOGIC_CPU_FEATURE_OVERRIDES_H
> >+
> >+/*
> >+ * Most of the properties are in cpu->options
> >+ */
> >+#define cpu_has_netlogic_cache      1
> >+
> >+#endif /* __ASM_MACH_NETLOGIC_CPU_FEATURE_OVERRIDES_H */
> 
> Although this will probably work, you will likely get better
> performance if you supply static default values for as many
> overrides as possible.

True, we will miss possible compile-time optimizations, will 
look at this.

Thanks!
JC.
-- 
Jayachandran C.
jayachandranc@netlogicmicro.com                  (Netlogic Microsystems)
jchandra@freebsd.org                               (The FreeBSD Project)

<Prev in Thread] Current Thread [Next in Thread>