| To: | Jamie Iles <jamie@jamieiles.com> |
|---|---|
| Subject: | Re: [PATCH V2 05/10] MIPS: lantiq: add watchdog support |
| From: | Sergei Shtylyov <sshtylyov@mvista.com> |
| Date: | Thu, 03 Mar 2011 14:21:04 +0300 |
| Cc: | John Crispin <blogic@openwrt.org>, Ralf Baechle <ralf@linux-mips.org>, Ralph Hempel <ralph.hempel@lantiq.com>, Wim Van Sebroeck <wim@iguana.be>, linux-mips@linux-mips.org, linux-watchdog@vger.kernel.org |
| In-reply-to: | <20110303101527.GE2955@pulham.picochip.com> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <1298996006-15960-1-git-send-email-blogic@openwrt.org> <1298996006-15960-6-git-send-email-blogic@openwrt.org> <4D6E286D.9050100@mvista.com> <20110303101527.GE2955@pulham.picochip.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.2.14) Gecko/20110221 Thunderbird/3.1.8 |
Hello. On 03-03-2011 13:15, Jamie Iles wrote: +static int +ltq_wdt_remove(struct platform_device *dev)
No, I think this should be __devexit and the probe function should be __devinit. When assigning the exit function to the platform_driver it should be surrounded with __devexit_p(). Why? Is WDT really a hotplug device? Jamie WBR, Sergei |
| Previous by Date: | [PATCH V3 10/10] MIPS: lantiq: add more gpio drivers, John Crispin |
|---|---|
| Next by Date: | Re: [PATCH V3 05/10] MIPS: lantiq: add watchdog support, Sergei Shtylyov |
| Previous by Thread: | Re: [PATCH V2 05/10] MIPS: lantiq: add watchdog support, Jamie Iles |
| Next by Thread: | [PATCH V2 09/10] MIPS: lantiq: add machtypes for lantiq eval kits, John Crispin |
| Indexes: | [Date] [Thread] [Top] [All Lists] |