| To: | Sergei Shtylyov <sshtylyov@mvista.com> |
|---|---|
| Subject: | Re: [PATCH V2 05/10] MIPS: lantiq: add watchdog support |
| From: | John Crispin <blogic@openwrt.org> |
| Date: | Wed, 02 Mar 2011 16:44:08 +0100 |
| Cc: | Ralf Baechle <ralf@linux-mips.org>, Ralph Hempel <ralph.hempel@lantiq.com>, Wim Van Sebroeck <wim@iguana.be>, linux-mips@linux-mips.org, linux-watchdog@vger.kernel.org |
| In-reply-to: | <4D6E286D.9050100@mvista.com> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <1298996006-15960-1-git-send-email-blogic@openwrt.org> <1298996006-15960-6-git-send-email-blogic@openwrt.org> <4D6E286D.9050100@mvista.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.12) Gecko/20100913 Icedove/3.0.7 |
Hi Sergei, thanks for the comments, one question below >> + /* we do not need to enable the clock as it is always running */ >> + clk = clk_get(&pdev->dev, "io"); > > clk_get() may fail... > lantiq socs have 2 static clock that are always running. so i think it is safe to assume that this wont fail unless someone renames the clocks. alternatively i could add a if (!clk) BUG(); but i am not sure if it is required. thanks, John |
| Previous by Date: | Re: [PATCH V2 05/10] MIPS: lantiq: add watchdog support, John Crispin |
|---|---|
| Next by Date: | Re: [PATCH V2 05/10] MIPS: lantiq: add watchdog support, Ralf Baechle |
| Previous by Thread: | Re: [PATCH V2 05/10] MIPS: lantiq: add watchdog support, Sergei Shtylyov |
| Next by Thread: | Re: [PATCH V2 05/10] MIPS: lantiq: add watchdog support, Jamie Iles |
| Indexes: | [Date] [Thread] [Top] [All Lists] |