linux-mips
[Top] [All Lists]

Re: [PATCH] Network driver for PMC-Sierra MSP71xx TSMAC.

To: "Anoop P.A" <anoop.pa@gmail.com>
Subject: Re: [PATCH] Network driver for PMC-Sierra MSP71xx TSMAC.
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Thu, 24 Feb 2011 09:35:35 -0800
Cc: davem@davemloft.net, khilman@deeprootsystems.com, cyril@ti.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org
In-reply-to: <1298548660-10546-1-git-send-email-anoop.pa@gmail.com>
Organization: Vyatta
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1298548660-10546-1-git-send-email-anoop.pa@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
On Thu, 24 Feb 2011 17:27:40 +0530
"Anoop P.A" <anoop.pa@gmail.com> wrote:
> +const char version[] = "pmcmsp_tsmac.c:v2.0 01/09/2007, PMC-Sierra\n";
> +const char cardname[] = "pmcmsp_tsmac";

All data and functions that are only used by this driver should be marked 
static.

> +const char drv_reldate[] = "$Date: 2010/07/15 07:38:59 $";
> +const char drv_file[] = __FILE__;

This is bogus noise.


-- 

<Prev in Thread] Current Thread [Next in Thread>