linux-mips
[Top] [All Lists]

Re: [PATCH v5] EHCI bus glue for on-chip PMC MSP USB controller

To: Anoop P A <anoop.pa@gmail.com>
Subject: Re: [PATCH v5] EHCI bus glue for on-chip PMC MSP USB controller
From: Dan Carpenter <error27@gmail.com>
Date: Thu, 24 Feb 2011 14:28:19 +0300
Cc: "gregkh @ suse . de" <gregkh@suse.de>, "dbrownell @ users . sourceforge . net" <dbrownell@users.sourceforge.net>, "stern @ rowland . harvard . edu" <stern@rowland.harvard.edu>, "pkondeti @ codeaurora . org" <pkondeti@codeaurora.org>, "jacob . jun . pan @ intel . com" <jacob.jun.pan@intel.com>, "linux-usb @ vger . kernel . org" <linux-usb@vger.kernel.org>, "alek . du @ intel . com" <alek.du@intel.com>, "linux-kernel @ vger . kernel . org" <linux-kernel@vger.kernel.org>, "gadiyar @ ti . com" <gadiyar@ti.com>, "ralf @ linux-mips . org" <ralf@linux-mips.org>, "linux-mips @ linux-mips . org" <linux-mips@linux-mips.org>, Greg KH <greg@kroah.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-type :content-disposition:in-reply-to:user-agent; bh=oMxKhlE43hc5cZ/u1Yi5GvxQdBauK7wMNFeSk90Tmms=; b=E8AtBi/FzEfFRyRu5ZBbSYRZ0ZGg8l2fwZmzUWAIcYhKYfmr8tSau9HrLgHeHgy/hE axC5oY083XFiBGTq5Iuz1TWpjnKQAKy2H74dPWJZMOz3yUz2zlI5Yjr5/6FDtghk3MVo 4pAXH0LVb39nahVaxHDkeAMjfbctytwDFeYVg=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; b=XzwYNrNdavqPo/7n0PuWYlDDPB2dByCVzSIceq3FrMPb2Fi2+SAIq2FxIsBar6n0Ry nuV5WXe5SR3fJFjCqSbFYe04wtN97lL+FxPMGzrYAogwgQBqR+sXM1aeMtVH6nyyejxm 1t0tVHJU/TgvV466geKVvLG23lQyBo/yatW0Q=
In-reply-to: <1298542755.9950.277.camel@paanoop1-desktop>
Mail-followup-to: Dan Carpenter <error27@gmail.com>, Anoop P A <anoop.pa@gmail.com>, "gregkh @ suse . de" <gregkh@suse.de>, "dbrownell @ users . sourceforge . net" <dbrownell@users.sourceforge.net>, "stern @ rowland . harvard . edu" <stern@rowland.harvard.edu>, "pkondeti @ codeaurora . org" <pkondeti@codeaurora.org>, "jacob . jun . pan @ intel . com" <jacob.jun.pan@intel.com>, "linux-usb @ vger . kernel . org" <linux-usb@vger.kernel.org>, "alek . du @ intel . com" <alek.du@intel.com>, "linux-kernel @ vger . kernel . org" <linux-kernel@vger.kernel.org>, "gadiyar @ ti . com" <gadiyar@ti.com>, "ralf @ linux-mips . org" <ralf@linux-mips.org>, "linux-mips @ linux-mips . org" <linux-mips@linux-mips.org>, Greg KH <greg@kroah.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <4D5ABB65.3090101@parrot.com> <1298388933-13707-1-git-send-email-anoop.pa@gmail.com> <20110222200427.GB1966@bicker> <1298467343.9950.119.camel@paanoop1-desktop> <20110223170205.GE19898@bicker> <1298542755.9950.277.camel@paanoop1-desktop>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.20 (2009-06-14)
On Thu, Feb 24, 2011 at 03:49:15PM +0530, Anoop P A wrote:
> > Also this is dead code.  No one will complain, if you just delete it.
> You mean entire ehci_msp_suspend() ??
> 

Sure why not?  It's not really ready to submit.  People can't complain
about it if you don't submit it.

(Understand that I'm from the peanut gallery.  I'm not in anyway a 
maintainer of this code and my suggestions carry very little weight).

regards,
dan carpenter

<Prev in Thread] Current Thread [Next in Thread>