linux-mips
[Top] [All Lists]

Re: [RFC PATCH 02/10] MIPS: Octeon: Add device tree source files.

To: David Daney <ddaney@caviumnetworks.com>
Subject: Re: [RFC PATCH 02/10] MIPS: Octeon: Add device tree source files.
From: David Gibson <david@gibson.dropbear.id.au>
Date: Thu, 24 Feb 2011 13:14:40 +1100
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, devicetree-discuss@lists.ozlabs.org, grant.likely@secretlab.ca, linux-kernel@vger.kernel.org
In-reply-to: <4D65BB17.4060703@caviumnetworks.com>
Mail-followup-to: David Gibson <david@gibson.dropbear.id.au>, David Daney <ddaney@caviumnetworks.com>, linux-mips@linux-mips.org, ralf@linux-mips.org, devicetree-discuss@lists.ozlabs.org, grant.likely@secretlab.ca, linux-kernel@vger.kernel.org
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1298408274-20856-1-git-send-email-ddaney@caviumnetworks.com> <1298408274-20856-3-git-send-email-ddaney@caviumnetworks.com> <20110223000759.GA26300@yookeroo> <4D655AB6.80400@caviumnetworks.com> <20110223234923.GA4932@yookeroo> <4D65BB17.4060703@caviumnetworks.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, Feb 23, 2011 at 05:57:43PM -0800, David Daney wrote:
> On 02/23/2011 03:49 PM, David Gibson wrote:
> >On Wed, Feb 23, 2011 at 11:06:30AM -0800, David Daney wrote:
> >>On 02/22/2011 04:07 PM, David Gibson wrote:
> >>>On Tue, Feb 22, 2011 at 12:57:46PM -0800, David Daney wrote:
> >>>>Signed-off-by: David Daney<ddaney@caviumnetworks.com>
> >>>>---
> >>>>  arch/mips/cavium-octeon/.gitignore      |    2 +
> >>>>  arch/mips/cavium-octeon/Makefile        |   13 ++
> >>>>  arch/mips/cavium-octeon/octeon_3xxx.dts |  314 
> >>>> +++++++++++++++++++++++++++++++
> >>>>  arch/mips/cavium-octeon/octeon_68xx.dts |   99 ++++++++++
> >>>>  4 files changed, 428 insertions(+), 0 deletions(-)
> >>>>  create mode 100644 arch/mips/cavium-octeon/.gitignore
> >>>>  create mode 100644 arch/mips/cavium-octeon/octeon_3xxx.dts
> >>>>  create mode 100644 arch/mips/cavium-octeon/octeon_68xx.dts
> >>>>
> >>>>diff --git a/arch/mips/cavium-octeon/.gitignore 
> >>>>b/arch/mips/cavium-octeon/.gitignore
> >>>>new file mode 100644
> >>>>index 0000000..39c9686
> >>>>--- /dev/null
> >>>>+++ b/arch/mips/cavium-octeon/.gitignore
> >>>>@@ -0,0 +1,2 @@
> >>>>+*.dtb.S
> >>>
> >>>.dtb.S?
> >>
> >>I think I have the correct .gitignore syntax.
> >
> >What I meant was, where are you generating .dtb.S files that you need
> >to ignore them?
> >
> 
> They are a byproduct of $(call cmd,dtc).
> 
> Normally make removes them automatically, but if you abort at just
> the right time, they can be left around.
> 
> If it is objectionable, I can just remove that .gitignore bit.

No, if they're byproducts of cmd,dtc they should be there.  I'm just a
bit baffled as to why cmd,dtc would produce such byproducts.  dtc
itself will convert dts -> dtb without any extraneous intermediate
steps.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

<Prev in Thread] Current Thread [Next in Thread>